%.f should have zero precision, not default precision

cbac016c · Arthur Danskin · Victor Zverovich · c03f55ec · cbac016c · cbac016c
Commit cbac016c authored Mar 30, 2017 by Arthur Danskin Committed by Victor Zverovich Apr 08, 2017
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

fmt/printf.h fmt/printf.h +2 -0

test/printf-test.cc test/printf-test.cc +3 -0

No files found.
--- a/fmt/printf.h
+++ b/fmt/printf.h
@@ -439,6 +439,8 @@ void PrintfFormatter<Char, AF>::format(BasicCStringRef<Char> format_str) {
      } else if (*s == '*') {
        ++s;
        spec.precision_ = internal::PrecisionHandler().visit(get_arg(s));
+      } else {
+        spec.precision_ = 0;
      }
    }


--- a/test/printf-test.cc
+++ b/test/printf-test.cc
@@ -401,6 +401,9 @@ TEST(PrintfTest, LongLong) {

 TEST(PrintfTest, Float) {
  EXPECT_PRINTF("392.650000", "%f", 392.65);
+  EXPECT_PRINTF("392.65", "%.2f", 392.65);
+  EXPECT_PRINTF("392.6", "%.1f", 392.65);
+  EXPECT_PRINTF("393", "%.f", 392.65);
  EXPECT_PRINTF("392.650000", "%F", 392.65);
  EXPECT_PRINTF("392.65", "%s", 392.65);
  char buffer[BUFFER_SIZE];