Fix Range with clang + opt builds + ASAN

Summary: [Folly] Fix Range with clang + opt builds + ASAN, where functions marked with `__attribute__((__noinline__))` are getting inlined.

Reviewed By: nbronson

Differential Revision: D8597928

fbshipit-source-id: c963feea270b9e28e118d196950b04d8457b9c66

folly/detail/RangeSse42.cpp

@@ -45,6 +45,7 @@ size_t qfind_first_byte_of_sse42(
 #include <smmintrin.h>
 
 #include <folly/Likely.h>
+#include <folly/detail/Sse.h>
 
 namespace folly {
 namespace detail {
@@ -68,24 +69,6 @@ static inline size_t nextAlignedIndex(const char* arr) {
       - firstPossible;
 }
 
-FOLLY_DISABLE_ADDRESS_SANITIZER static __m128i _mm_loadu_si128_noasan(
-    __m128i const* const p) {
-  return _mm_loadu_si128(p);
-}
-FOLLY_ALWAYS_INLINE static __m128i _mm_loadu_si128_unchecked(
-    __m128i const* const p) {
-  return kIsSanitizeAddress ? _mm_loadu_si128_noasan(p) : _mm_loadu_si128(p);
-}
-
-FOLLY_DISABLE_ADDRESS_SANITIZER static __m128i _mm_load_si128_noasan(
-    __m128i const* const p) {
-  return _mm_load_si128(p);
-}
-FOLLY_ALWAYS_INLINE static __m128i _mm_load_si128_unchecked(
-    __m128i const* const p) {
-  return kIsSanitizeAddress ? _mm_load_si128_noasan(p) : _mm_load_si128(p);
-}
-
 // helper method for case where needles.size() <= 16
 size_t qfind_first_byte_of_needles16(
     const StringPieceLite haystack,

folly/detail/Sse.cpp

+/*
+ * Copyright 2018-present Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <folly/detail/Sse.h>
+
+namespace folly {
+namespace detail {
+
+#if FOLLY_SSE_PREREQ(2, 0)
+
+FOLLY_DISABLE_ADDRESS_SANITIZER __m128i
+_mm_loadu_si128_noasan(__m128i const* const p) {
+  return _mm_loadu_si128(p);
+}
+
+FOLLY_DISABLE_ADDRESS_SANITIZER __m128i
+_mm_load_si128_noasan(__m128i const* const p) {
+  return _mm_load_si128(p);
+}
+
+#endif
+
+} // namespace detail
+} // namespace folly

folly/detail/Sse.h

+/*
+ * Copyright 2018-present Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <folly/Portability.h>
+
+#if FOLLY_SSE_PREREQ(2, 0)
+
+#include <emmintrin.h>
+
+#endif
+
+namespace folly {
+namespace detail {
+
+#if FOLLY_SSE_PREREQ(2, 0)
+
+FOLLY_DISABLE_ADDRESS_SANITIZER __m128i
+_mm_loadu_si128_noasan(__m128i const* const p);
+FOLLY_ALWAYS_INLINE FOLLY_ATTR_VISIBILITY_HIDDEN __m128i
+_mm_loadu_si128_unchecked(__m128i const* const p) {
+  return kIsSanitizeAddress ? _mm_loadu_si128_noasan(p) : _mm_loadu_si128(p);
+}
+
+FOLLY_DISABLE_ADDRESS_SANITIZER __m128i
+_mm_load_si128_noasan(__m128i const* const p);
+FOLLY_ALWAYS_INLINE FOLLY_ATTR_VISIBILITY_HIDDEN __m128i
+_mm_load_si128_unchecked(__m128i const* const p) {
+  return kIsSanitizeAddress ? _mm_load_si128_noasan(p) : _mm_load_si128(p);
+}
+
+#endif
+
+} // namespace detail
+} // namespace folly