Commit 1d2bff8d authored by Chad Austin's avatar Chad Austin Committed by Facebook GitHub Bot

use backtrace(2) on all Apple platforms

Summary: I don't recall what previous intermediate state justified guarding use of backtrace with __APPLE__ and FOLLY_USE_SYMBOLIZER, but it no longer applies.

Reviewed By: yfeldblum, luciang

Differential Revision: D23881192

fbshipit-source-id: b3ca829f9c738f50f7ab7e038348ec3df65ae4b9
parent 8be3153a
...@@ -126,7 +126,7 @@ ssize_t getStackTraceInPlace( ...@@ -126,7 +126,7 @@ ssize_t getStackTraceInPlace(
ssize_t getStackTraceSafe( ssize_t getStackTraceSafe(
FOLLY_MAYBE_UNUSED uintptr_t* addresses, FOLLY_MAYBE_UNUSED uintptr_t* addresses,
FOLLY_MAYBE_UNUSED size_t maxAddresses) { FOLLY_MAYBE_UNUSED size_t maxAddresses) {
#if defined(__APPLE__) && FOLLY_USE_SYMBOLIZER #if defined(__APPLE__)
// While Apple platforms support libunwind, the unw_init_local, // While Apple platforms support libunwind, the unw_init_local,
// unw_step step loop does not cross the boundary from async signal // unw_step step loop does not cross the boundary from async signal
// handlers to the aborting code, while `backtrace` from execinfo.h // handlers to the aborting code, while `backtrace` from execinfo.h
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment