Commit 39fc6b12 authored by Nicholas Ormrod's avatar Nicholas Ormrod Committed by Facebook GitHub Bot

Make a platform010 contbuild config

Summary:
Ensure that folly continues to work with platform010. Since folly is depended on my many projects, some on platform009 and some on platform010, we should make sure it continues to work with both platforms.

Since many platform010 projects depend on folly, folly's platform010 coverage is actually pretty good. However, changes to test files in folly have been observed to break with 010-incompatible changes (such as D33143441 (https://github.com/facebook/folly/commit/43ba86e231ab5cb158835433df656d3026c3c6cf) and D32930335 (https://github.com/facebook/folly/commit/cec3fcac4dded35478747e4d9b8e533b491140e1)); these are not caught by dependent projects' configs.

Reviewed By: yfeldblum, meyering

Differential Revision: D33172025

fbshipit-source-id: 94b46471bee604289b3b6a11763a27c6e3ed9fcf
parent c0b795ac
...@@ -84,13 +84,25 @@ TEST(TestUtilsRangeTest, Wide) { ...@@ -84,13 +84,25 @@ TEST(TestUtilsRangeTest, Wide) {
EXPECT_EQ(PrintToString(kHelloString), PrintToString(kHelloStringPiece)); EXPECT_EQ(PrintToString(kHelloString), PrintToString(kHelloStringPiece));
} }
TEST(TestUtilsRangeTest, Utf16) { // gtest-printer.h has added an overload to PrintTo for u16string, which is
// present in platform010 but not present in platform009:
// void PrintTo(const ::std::u16string& s, ::std::ostream* os)
// Before this overload existed, u16string was printed as an array of unicode
// characters, "{ U+0068, U+0065, U+006C, U+006C, U+006F }", but this has been
// prettified to "u\"hello\"". As such, it no longer matches the string piece
// printer.
// This is not worth fixing: adding a PrintTo overload for Range<const char16_t>
// and friends would be liable to break when gtest further changes their
// printer. Disable the test; no other folly tests are broken on account of this
// PrintTo discrepancy.
TEST(TestUtilsRangeTest, DISABLED_Utf16) {
constexpr auto kHelloStringPiece = u"hello"_sp; constexpr auto kHelloStringPiece = u"hello"_sp;
const auto kHelloString = u"hello"s; const auto kHelloString = u"hello"s;
EXPECT_EQ(PrintToString(kHelloString), PrintToString(kHelloStringPiece)); EXPECT_EQ(PrintToString(kHelloString), PrintToString(kHelloStringPiece));
} }
TEST(TestUtilsRangeTest, Utf32) { // Also broken on platform010, as with TestUtilsRangeTest.Utf16
TEST(TestUtilsRangeTest, DISABLED_Utf32) {
constexpr auto kHelloStringPiece = U"hello"_sp; constexpr auto kHelloStringPiece = U"hello"_sp;
const auto kHelloString = U"hello"s; const auto kHelloString = U"hello"s;
EXPECT_EQ(PrintToString(kHelloString), PrintToString(kHelloStringPiece)); EXPECT_EQ(PrintToString(kHelloString), PrintToString(kHelloStringPiece));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment