Commit 4f5128bb authored by Yedidya Feldblum's avatar Yedidya Feldblum Committed by Facebook GitHub Bot

work around miscompile in parallel-map test

Summary: Some versions of gcc miscompile the code in the parallel-map exception test. Work around the miscompile by adding an extra log line.

Reviewed By: Orvid

Differential Revision: D26509079

fbshipit-source-id: 1474437d96aeabad0294bcb395b7baec229eb9ba
parent f4f3b9c2
...@@ -156,6 +156,9 @@ TEST(Pmap, Rvalues) { ...@@ -156,6 +156,9 @@ TEST(Pmap, Rvalues) {
} }
TEST(Pmap, Exception) { TEST(Pmap, Exception) {
#if __GNUC__ == 7 && __GNUC_MINOR__ == 5 && !__clang__
LOG(INFO) << "some versions of gcc miscompile the code below without this";
#endif
std::vector<char const*> input{"a"}; std::vector<char const*> input{"a"};
EXPECT_THROW(from(input) | pmap(To<int>()) | count, std::runtime_error); EXPECT_THROW(from(input) | pmap(To<int>()) | count, std::runtime_error);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment