Commit 58815ebf authored by Joe Loser's avatar Joe Loser Committed by Facebook Github Bot

Cut GCC 5.0 preprocessor guard in Traits.h (#1151)

Summary:
- Cut `#if __GNUC_PREREQ(5, 0)` preprocessor directive as folly does not
  support any GCC version lower than 5.1.
- Change from `FOLLY_GNU_DISABLE_WARNING` to `FOLLY_GCC_DISABLE_WARNING`
  since Clang does not support `-Wbool-compare` option.
Pull Request resolved: https://github.com/facebook/folly/pull/1151

Reviewed By: Orvid

Differential Revision: D15618528

Pulled By: yfeldblum

fbshipit-source-id: 039e0aad617ccb40392505a6f4585e93d52dc81c
parent 1a8553b8
...@@ -657,9 +657,7 @@ namespace detail { ...@@ -657,9 +657,7 @@ namespace detail {
// in order to not prevent all calling code from using it. // in order to not prevent all calling code from using it.
FOLLY_PUSH_WARNING FOLLY_PUSH_WARNING
FOLLY_GNU_DISABLE_WARNING("-Wsign-compare") FOLLY_GNU_DISABLE_WARNING("-Wsign-compare")
#if __GNUC_PREREQ(5, 0) FOLLY_GCC_DISABLE_WARNING("-Wbool-compare")
FOLLY_GNU_DISABLE_WARNING("-Wbool-compare")
#endif
FOLLY_MSVC_DISABLE_WARNING(4388) // sign-compare FOLLY_MSVC_DISABLE_WARNING(4388) // sign-compare
FOLLY_MSVC_DISABLE_WARNING(4804) // bool-compare FOLLY_MSVC_DISABLE_WARNING(4804) // bool-compare
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment