Commit 61684201 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Switch future's Core<T> to std::is_nothrow_constructible

Summary:
MSVC has issues with the way it was written, so just use the standard version instead.

Upstream bug report: https://developercommunity.visualstudio.com/content/problem/80433/incorrect-error-c2462-cannot-define-a-type-in-a-ne.html

Reviewed By: yfeldblum

Differential Revision: D5427029

fbshipit-source-id: ae3737175d5b8e9738ed6b9573412d1d566b0e1c
parent 112ec135
...@@ -91,7 +91,7 @@ class Core final { ...@@ -91,7 +91,7 @@ class Core final {
template <typename... Args> template <typename... Args>
explicit Core(in_place_t, Args&&... args) noexcept( explicit Core(in_place_t, Args&&... args) noexcept(
noexcept(::new (nullptr) T(std::declval<Args&&>()...))) std::is_nothrow_constructible<T, Args&&...>::value)
: result_(in_place, in_place, std::forward<Args>(args)...), : result_(in_place, in_place, std::forward<Args>(args)...),
fsm_(State::OnlyResult), fsm_(State::OnlyResult),
attached_(1) {} attached_(1) {}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment