Port fbstring_core to big-endian architectures.
Summary: There's 2 ways this could be implemented - either as a series of preprocessor blocks depending on target architecture (as I have implemented it here), or by encapsulating access to MediumLarge::capacity_ within getters/setters as in a similar manner to setSmallSize() and smallSize(). The first option makes the code a bit harder to read, but the second option changes the existing control flow a bit which could slightly alter performance. I opted for the first so as to keep the existing amd64 flow untouched, but can easily change the pull request to the second option to keep code readability a priority. Closes https://github.com/facebook/folly/pull/244 Reviewed By: @Gownta Differential Revision: D2306568 Pulled By: @JoelMarcey
Showing
This diff is collapsed.
Please register or sign in to comment