Commit 845936ce authored by Orvid King's avatar Orvid King Committed by Facebook Github Bot

Remove the fd overloads of AsyncPipe components

Summary: They're dead

Reviewed By: yfeldblum

Differential Revision: D14838871

fbshipit-source-id: 4b136d7a5914a1564f32bb87e6bec2b8d1411829
parent fab6cad7
...@@ -45,14 +45,8 @@ class AsyncPipeReader : public EventHandler, ...@@ -45,14 +45,8 @@ class AsyncPipeReader : public EventHandler,
return UniquePtr(new AsyncPipeReader(eventBase, pipeFd)); return UniquePtr(new AsyncPipeReader(eventBase, pipeFd));
} }
static UniquePtr newReader(folly::EventBase* eventBase, int pipeFd) {
return newReader(eventBase, NetworkSocket::fromFd(pipeFd));
}
AsyncPipeReader(folly::EventBase* eventBase, NetworkSocket pipeFd) AsyncPipeReader(folly::EventBase* eventBase, NetworkSocket pipeFd)
: EventHandler(eventBase, pipeFd), fd_(pipeFd) {} : EventHandler(eventBase, pipeFd), fd_(pipeFd) {}
AsyncPipeReader(folly::EventBase* eventBase, int pipeFd)
: AsyncPipeReader(eventBase, NetworkSocket::fromFd(pipeFd)) {}
/** /**
* Set the read callback and automatically install/uninstall the handler * Set the read callback and automatically install/uninstall the handler
...@@ -113,14 +107,8 @@ class AsyncPipeWriter : public EventHandler, ...@@ -113,14 +107,8 @@ class AsyncPipeWriter : public EventHandler,
return UniquePtr(new AsyncPipeWriter(eventBase, pipeFd)); return UniquePtr(new AsyncPipeWriter(eventBase, pipeFd));
} }
static UniquePtr newWriter(folly::EventBase* eventBase, int pipeFd) {
return newWriter(eventBase, NetworkSocket::fromFd(pipeFd));
}
AsyncPipeWriter(folly::EventBase* eventBase, NetworkSocket pipeFd) AsyncPipeWriter(folly::EventBase* eventBase, NetworkSocket pipeFd)
: EventHandler(eventBase, pipeFd), fd_(pipeFd) {} : EventHandler(eventBase, pipeFd), fd_(pipeFd) {}
AsyncPipeWriter(folly::EventBase* eventBase, int pipeFd)
: AsyncPipeWriter(eventBase, NetworkSocket::fromFd(pipeFd)) {}
/** /**
* Asynchronously write the given iobuf to this pipe, and invoke the callback * Asynchronously write the given iobuf to this pipe, and invoke the callback
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment