Commit 90678e67 authored by Andrii Grynenko's avatar Andrii Grynenko Committed by Facebook Github Bot 7

Don't re-throw exceptions from default FiberManager exception handler

Summary: It's very unlikely that caller will handle such exceptions and FiberManager can proceed even if one task failed. DFATAL will ensure we still fail on such exceptions in debug builds.

Reviewed By: yfeldblum

Differential Revision: D3273573

fb-gh-sync-id: 55eba19c16429a3c89a2fdf5363fd4b55b3998a2
fbshipit-source-id: 55eba19c16429a3c89a2fdf5363fd4b55b3998a2
parent 8d90d07e
......@@ -527,11 +527,9 @@ FiberManager::FiberManager(
LOG(DFATAL) << "Exception " << typeid(e).name() << " with message '"
<< e.what() << "' was thrown in "
<< "FiberManager with context '" << context << "'";
throw;
} catch (...) {
LOG(DFATAL) << "Unknown exception was thrown in FiberManager with "
<< "context '" << context << "'";
throw;
}
}),
timeoutManager_(std::make_shared<TimeoutController>(*loopController_)),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment