Revert D15177816: [folly] Fix de-ref of evb after evb deletion

Differential Revision:
D15177816

Original commit changeset: 7298fcdc3a73

fbshipit-source-id: fc62ec2ecf7fb06bc60cdd0c33b17b53fe35af19

folly/io/async/EventBase.cpp

@@ -163,10 +163,6 @@ EventBase::~EventBase() {
     virtualEventBaseDestroyFuture.get();
   }
 
-  // Destruction of the wheel timer may trigger cancellation callbacks.
-  // Run those before destruction callbacks.
-  wheelTimer_.reset();
-
   // Call all destruction callbacks, before we start cleaning up our state.
   while (!onDestructionCallbacks_.rlock()->empty()) {
     OnDestructionCallback::List callbacks;

folly/io/async/test/EventBaseTest.cpp

@@ -2129,28 +2129,3 @@ TEST(EventBaseTest, RunOnDestructionAddCallbackWithinCallback) {
   }
   EXPECT_EQ(2, callbacksCalled);
 }
-
-class TestWheelTimeout : public HHWheelTimer::Callback {
- public:
-  ~TestWheelTimeout() override = default;
-
-  void callbackCanceled() noexcept override {
-    // This is invoked when the EventBase is destroyed
-    canceled = true;
-  }
-
-  void timeoutExpired() noexcept override {}
-
-  bool canceled{false};
-};
-
-TEST(EventBaseTest, WheelTimerWhileDestroyingEvb) {
-  TestWheelTimeout timeout;
-
-  {
-    EventBase eb;
-    eb.runOnDestruction([&]() { EXPECT_TRUE(timeout.canceled); });
-    auto& timer = eb.timer();
-    timer.scheduleTimeout(&timeout, std::chrono::seconds(10));
-  }
-}