Commit b0e08c4a authored by Adam Simpkins's avatar Adam Simpkins Committed by Facebook Github Bot

improve the code that searches for dumpbin.exe

Summary:
Fix dyndeps.py to find dumpbin.exe in more situations.

Previously the code looked for dumpbin.exe under Visual Studio directories
named either `BuildTools` or `Community`.  On a system with an MSVC 2017
Professional install it is instead located under a directory named
`Professional`.  This updates the glob to allow any directory name here.

Reviewed By: pkaush

Differential Revision: D16207692

fbshipit-source-id: 1a57ec29653a89fd3e751b3e4408a298b4632b11
parent c82e22f5
...@@ -125,13 +125,7 @@ class WinDeps(DepBase): ...@@ -125,13 +125,7 @@ class WinDeps(DepBase):
( (
"C:/Program Files (x86)/" "C:/Program Files (x86)/"
"Microsoft Visual Studio/" "Microsoft Visual Studio/"
"*/BuildTools/VC/Tools/" "*/*/VC/Tools/"
"MSVC/*/bin/Hostx64/x64/dumpbin.exe"
),
(
"C:/Program Files (x86)/"
"Microsoft Visual Studio/"
"*/Community/VC/Tools/"
"MSVC/*/bin/Hostx64/x64/dumpbin.exe" "MSVC/*/bin/Hostx64/x64/dumpbin.exe"
), ),
( (
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment