Fix default VirtualEventBase access race exposed by TSAN

Reviewed By: iahs

Differential Revision: D19873296

fbshipit-source-id: f92785feb33be09bdef4c047532b4bd3dd42972e

folly/io/async/EventBase.cpp

@@ -498,9 +498,11 @@ ssize_t EventBase::loopKeepAliveCount() {
 void EventBase::applyLoopKeepAlive() {
   auto keepAliveCount = loopKeepAliveCount();
   // Make sure default VirtualEventBase won't hold EventBase::loop() forever.
-  if (virtualEventBase_ && virtualEventBase_->keepAliveCount() == 1) {
+  if (auto virtualEventBase = tryGetVirtualEventBase()) {
+    if (virtualEventBase->keepAliveCount() == 1) {
       --keepAliveCount;
     }
+  }
 
   if (loopKeepAliveActive_ && keepAliveCount == 0) {
     // Restore the notification queue internal flag
@@ -844,6 +846,13 @@ VirtualEventBase& EventBase::getVirtualEventBase() {
   return *virtualEventBase_;
 }
 
+VirtualEventBase* EventBase::tryGetVirtualEventBase() {
+  if (folly::test_once(virtualEventBaseInitFlag_)) {
+    return virtualEventBase_.get();
+  }
+  return nullptr;
+}
+
 EventBase* EventBase::getEventBase() {
   return this;
 }

folly/io/async/EventBase.h

@@ -828,6 +828,8 @@ class EventBase : public TimeoutManager,
   }
 
  private:
+  folly::VirtualEventBase* tryGetVirtualEventBase();
+
   void applyLoopKeepAlive();
 
   ssize_t loopKeepAliveCount();