Commit e01c5188 authored by Adam Simpkins's avatar Adam Simpkins Committed by Facebook Github Bot

fix the thrift CMake rules to add dependencies on the thrift compiler

Summary:
Update the thrift C++ and Python CMake rules to indicate that the output also
depends on the thrift compiler itself.

Previously the C++ rule indicated that the output depended on the thrift
template files, which caught most cases when the thrift compiler was updated,
but wasn't fully correct.  The thrift templates were also removed and baked
into the thrift compiler binary in D16356056.

Reviewed By: yfeldblum, chadaustin

Differential Revision: D17401217

fbshipit-source-id: ae5cde7a7e5e07a74406a1b6f4469124187bc12f
parent c9299818
...@@ -121,7 +121,7 @@ function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE) ...@@ -121,7 +121,7 @@ function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE)
"${THRIFT_FILE}" "${THRIFT_FILE}"
DEPENDS DEPENDS
${ARG_DEPENDS} ${ARG_DEPENDS}
${THRIFT_TEMPLATE_FILES} "${FBTHRIFT_COMPILER}"
) )
# Now emit the library rule to compile the sources # Now emit the library rule to compile the sources
......
...@@ -93,6 +93,8 @@ function(add_fbthrift_py_library LIB_NAME THRIFT_FILE) ...@@ -93,6 +93,8 @@ function(add_fbthrift_py_library LIB_NAME THRIFT_FILE)
"${CMAKE_BINARY_DIR}" "${CMAKE_BINARY_DIR}"
MAIN_DEPENDENCY MAIN_DEPENDENCY
"${THRIFT_FILE}" "${THRIFT_FILE}"
DEPENDS
"${FBTHRIFT_COMPILER}"
) )
# We always want to pass the namespace as "" to this call: # We always want to pass the namespace as "" to this call:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment