Use folly Hash to hash strings in dynamic

Summary:
There should be no expectations on what hash is internally used in dynamic, so
we don't need to maintain compatibility with `fbstring`, which hasn't been used
as string storage in `dynamic` for quite a while.

Reviewed By: yfeldblum, ot

Differential Revision: D8824634

fbshipit-source-id: 6765472aeeacb55c68b058f5dcc128f6b400bc95

folly/dynamic.cpp

@@ -315,11 +315,8 @@ std::size_t dynamic::hash() const {
     return std::hash<double>()(getDouble());
   case BOOL:
     return std::hash<bool>()(getBool());
-  case STRING: {
-    // keep it compatible with FBString
-    const auto& str = getString();
-    return ::folly::hash::fnv32_buf(str.data(), str.size());
-  }
+  case STRING:
+    return Hash()(getString());
   }
   assume_unreachable();
 }