avoid syntactic copy elision for ExecutorBlockingGuard

Summary: It cannot yet be assumed in all places.

Reviewed By: MartinSherburn

Differential Revision: D28325332

fbshipit-source-id: b48a1f9d83c2171ef3912b33c55e9cf8fe294c32

folly/executors/CPUThreadPoolExecutor.cpp

@@ -19,6 +19,7 @@
 
 #include <atomic>
 #include <folly/Memory.h>
+#include <folly/Optional.h>
 #include <folly/concurrency/QueueObserver.h>
 #include <folly/executors/task_queue/PriorityLifoSemMPMCQueue.h>
 #include <folly/executors/task_queue/PriorityUnboundedBlockingQueue.h>
@@ -265,15 +266,12 @@ bool CPUThreadPoolExecutor::taskShouldStop(folly::Optional<CPUTask>& task) {
 
 void CPUThreadPoolExecutor::threadRun(ThreadPtr thread) {
   this->threadPoolHook_.registerThread();
-  auto guard = [&]() {
+  folly::Optional<ExecutorBlockingGuard> guard; // optional until C++17
   if (prohibitBlockingOnThreadPools_ == Options::Blocking::prohibit) {
-      return ExecutorBlockingGuard{
-          ExecutorBlockingGuard::ProhibitTag{}, executorName};
+    guard.emplace(ExecutorBlockingGuard::ProhibitTag{}, executorName);
   } else {
-      return ExecutorBlockingGuard{
-          ExecutorBlockingGuard::TrackTag{}, executorName};
+    guard.emplace(ExecutorBlockingGuard::TrackTag{}, executorName);
   }
-  }();
 
   thread->startupBaton.post();
   while (true) {