Commit f58a4bd5 authored by Joe Loser's avatar Joe Loser Committed by Facebook Github Bot

Closer to compiling with Clang

Summary:
This brings us closer to being able to compile the open
source version of Folly with Clang. There are a few other
open pull requests that need to be addressed to allow us to
compile on Clang without any warnings that aren't already
explicitly disabled. See pull requests #745 and #756.

Closes https://github.com/facebook/folly/pull/772

Reviewed By: simpkins

Differential Revision: D7021595

Pulled By: yfeldblum

fbshipit-source-id: 350b972c74502ca2bc147f21428c622b19805b89
parent 7f258ae5
...@@ -11,7 +11,7 @@ function(apply_folly_compile_options_to_target THETARGET) ...@@ -11,7 +11,7 @@ function(apply_folly_compile_options_to_target THETARGET)
"FOLLY_XLOG_STRIP_PREFIXES=\"${FOLLY_DIR_PREFIXES}\"" "FOLLY_XLOG_STRIP_PREFIXES=\"${FOLLY_DIR_PREFIXES}\""
) )
target_compile_options(${THETARGET} target_compile_options(${THETARGET}
PUBLIC PRIVATE
-g -g
-std=gnu++14 -std=gnu++14
-finput-charset=UTF-8 -finput-charset=UTF-8
...@@ -23,6 +23,7 @@ function(apply_folly_compile_options_to_target THETARGET) ...@@ -23,6 +23,7 @@ function(apply_folly_compile_options_to_target THETARGET)
-Wno-error=deprecated-declarations -Wno-error=deprecated-declarations
-Wno-sign-compare -Wno-sign-compare
-Wno-unused -Wno-unused
-Wno-inconsistent-missing-override
-Wunused-label -Wunused-label
-Wunused-result -Wunused-result
-Wnon-virtual-dtor -Wnon-virtual-dtor
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment