Move digits_to into .cpp
Summary: objdump was showing that the shiftXXX tables are being generated each time this file is included. For example, HHVM has about 200 of each of the 4 tables. Since each one is 512 bytes this is 400 KB. I'm not quite sure why this was happening -- I'd think that the linker would combine a constant table that was identical. I think the best thing to do here is just to use extern template. This way you there's only one copy of the table and you don't have to parse all of this code in every file Reviewed By: @yfeldblum Differential Revision: D2506571 fb-gh-sync-id: b01a522c536a2ff4136340245cacaa33897afefb
Showing
Please register or sign in to comment