- 20 May, 2014 40 commits
-
-
Nicholas Ormrod authored
Summary: small_vector is now object-exception safe for all container functions, except for input-iterators. That's a bold claim; probably incorrect. At the very least, it passes the same test suite as std::vector and fbvector. Aside: Clearly, no one uses erase(q1, q2) in the wild. Facebook: Nothing special. Test Plan: fbconfig -r folly && fbmake runtests fbconfig -r experimental/njormrod/stltest && fbmake runtests Reviewed By: andrei.alexandrescu@fb.com FB internal diff: D1319787
-
Nicholas Ormrod authored
Summary: small_vector is now object-exception safe for the general container functions (N3337 table 96). An amusing bug: in debug mode, swap would trigger an out-of-bounds operator[] access. This has been fixed. Facebook: Nothing fancy in the non-OSS files. Test Plan: fbconfig -r folly && fbmake runtests fbconfig -r experimental/njormrod/stltest && fbmake runtests Reviewed By: delong.j@fb.com FB internal diff: D1319574
-
Hans Fugal authored
Summary: @override-unit-failures Test Plan: Using it in D1322350 Reviewed By: hannesr@fb.com FB internal diff: D1322475
-
James Sedgwick authored
Summary: @override-unit-failures Add makeFuture variant which extracts the result contained in a Try and sticks it in a Future One use case: ``` template <typename Result, typename Op, typename... Args> Future<Result> wrapper(Op op, Args&&... args) { // ... do some stuff before... return op(std::forward<Args>(args)...).then([] (Try<Result>&& t) { // ... do some stuff after... return makeFuture<Result>(std::move(t)); }); } ``` With this makeFuture variant, "wrapper" doesn't need to be specialized for when Result is void Test Plan: employed in my code, will link to diff when ready Reviewed By: hans@fb.com FB internal diff: D1318047 -
Nicholas Ormrod authored
Summary: It is unused. Facebook: All hits from fbgs OneBitMutex have been deleted in this diff. Test Plan: fbconfig -r folly && fbmake runtests Reviewed By: delong.j@fb.com FB internal diff: D1319624
-
Nicholas Ormrod authored
Summary: Remvoed old fbvector folly/test/stl_test files. Have kept StlVectorTest, since it is still impressive and useful. Facebook: n/a Test Plan: enable StlVectorTest in the TARGETS fbconfig -r folly && fbmake runtests Reviewed By: robbert@fb.com FB internal diff: D1320254
-
Daniil Burdakov authored
Summary: subj Test Plan: tests Reviewed By: tjackson@fb.com FB internal diff: D1318719
-
Lucian Grijincu authored
Summary: c_str/data writes a terminator '\0' on each call. When multiple threads call c_str/data on the same string (e.g. small global constant) the string's cache line will bounce from cpu to cpu. Cpus report that most instructions are stalled (stalled-cycles-frontend/stalled-cycles-backend near 100%). Fix: check before setting '\0'. Test Plan: ** BEFORE ** - nothing defined ** gcc-4.8.1-glibc-2.17-fb $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 4.10s experimental/lucian/bench/StringTerminatorBenchmark.cpp Linking _build/opt/experimental/lucian/bench/string_terminator_benchmark... 2.40s _build/opt/experimental/lucian/bench/string_terminator_benchmark I0507 17:27:39.373522 28745 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 934.10ps 1.07G privat_std_1t 100.32% 931.08ps 1.07G static_fbs_1t 100.30% 931.33ps 1.07G privat_fbs_1t 100.42% 930.22ps 1.08G static_sp__1t 86986.52% 1.07ps 931.24G privat_sp__1t 81459.50% 1.15ps 872.07G static_std_32t 392.41ns 2.55M privat_std_32t 15072.69% 2.60ns 384.10M static_fbs_32t 102.41% 383.17ns 2.61M privat_fbs_32t 13643.61% 2.88ns 347.68M static_sp__32t 61032.25% 642.96ps 1.56G privat_sp__32t 74172.72% 529.06ps 1.89G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 2417478.451740 task-clock # 27.005 CPUs utilized 65,374 context-switches # 0.027 K/sec 4,270 CPU-migrations # 0.002 K/sec 2,594 page-faults # 0.001 K/sec 5,261,195,623,299 cycles # 2.176 GHz [25.09%] 5,072,634,235,091 stalled-cycles-frontend # 96.42% frontend cycles idle [30.01%] 3,848,759,938,052 stalled-cycles-backend # 73.15% backend cycles idle [30.01%] 614,983,033,652 instructions # 0.12 insns per cycle # 8.25 stalled cycles per insn [25.09%] 152,995,596,390 branches # 63.287 M/sec [30.01%] 24,501,018 branch-misses # 0.02% of all branches [25.94%] 66,298,370,215 L1-dcache-loads # 27.425 M/sec [30.03%] 1,642,188,850 L1-dcache-load-misses # 2.48% of all L1-dcache hits [30.02%] 968,142,977 LLC-loads # 0.400 M/sec [30.02%] 480,786,261 LLC-load-misses # 49.66% of all LL-cache hits [30.02%] 89.520960614 seconds time elapsed - #define FBSTRING_PERVERSE ** gcc-4.8.1-glibc-2.17-fb $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 4.25s experimental/lucian/bench/StringTerminatorBenchmark.cpp Linking _build/opt/experimental/lucian/bench/string_terminator_benchmark... 2.45s _build/opt/experimental/lucian/bench/string_terminator_benchmark I0507 17:24:26.487848 23720 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 932.63ps 1.07G privat_std_1t 100.95% 923.85ps 1.08G static_fbs_1t 100.04% 932.23ps 1.07G privat_fbs_1t 101.14% 922.07ps 1.08G static_sp__1t 30418.15% 3.07ps 326.16G privat_sp__1t 56775.39% 1.64ps 608.77G static_std_32t 388.57ns 2.57M privat_std_32t 16465.70% 2.36ns 423.75M static_fbs_32t 96.19% 403.98ns 2.48M privat_fbs_32t 16248.69% 2.39ns 418.16M static_sp__32t 81185.06% 478.63ps 2.09G privat_sp__32t 81470.69% 476.95ps 2.10G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 2486009.171842 task-clock # 27.241 CPUs utilized 64,538 context-switches # 0.026 K/sec 4,501 CPU-migrations # 0.002 K/sec 2,863 page-faults # 0.001 K/sec 5,413,507,764,726 cycles # 2.178 GHz [25.62%] 5,207,550,928,974 stalled-cycles-frontend # 96.20% frontend cycles idle [30.01%] 3,919,627,007,209 stalled-cycles-backend # 72.40% backend cycles idle [30.01%] 685,365,706,158 instructions # 0.13 insns per cycle # 7.60 stalled cycles per insn [25.62%] 148,798,151,350 branches # 59.854 M/sec [30.01%] 24,386,492 branch-misses # 0.02% of all branches [26.08%] 72,683,962,699 L1-dcache-loads # 29.237 M/sec [30.02%] 1,687,684,775 L1-dcache-load-misses # 2.32% of all L1-dcache hits [30.01%] 989,352,938 LLC-loads # 0.398 M/sec [30.02%] 484,825,665 LLC-load-misses # 49.00% of all LL-cache hits [30.02%] 91.259265010 seconds time elapsed - #define FBSTRING_CONSERVATIVE ** gcc-4.8.1-glibc-2.17-fb $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 0.18s experimental/lucian/bench/StringTerminatorBenchmark.cpp Linking _build/opt/experimental/lucian/bench/string_terminator_benchmark... 2.43s _build/opt/experimental/lucian/bench/string_terminator_benchmark I0507 17:30:58.246834 1571 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 1.44ps 692.61G privat_std_1t 193.01% 748.06fs 1.34T static_fbs_1t 399.47% 361.43fs 2.77T privat_fbs_1t 129.29% 1.12ps 895.50G static_sp__1t 78.99% 1.83ps 547.10G privat_sp__1t 56.22% 2.57ps 389.36G static_std_32t 478.67ps 2.09G privat_std_32t 100.30% 477.26ps 2.10G static_fbs_32t 100.52% 476.21ps 2.10G privat_fbs_32t 100.52% 476.22ps 2.10G static_sp__32t 99.57% 480.76ps 2.08G privat_sp__32t 100.06% 478.40ps 2.09G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 198000.887222 task-clock # 14.738 CPUs utilized 5,016 context-switches # 0.025 K/sec 2,536 CPU-migrations # 0.013 K/sec 4,717 page-faults # 0.024 K/sec 421,850,242,358 cycles # 2.131 GHz [25.31%] 209,633,195,159 stalled-cycles-frontend # 49.69% frontend cycles idle [30.32%] 6,252,451,713 stalled-cycles-backend # 1.48% backend cycles idle [30.21%] 874,096,942,441 instructions # 2.07 insns per cycle # 0.24 stalled cycles per insn [25.37%] 218,114,341,006 branches # 1101.583 M/sec [30.34%] 3,080,267 branch-misses # 0.00% of all branches [26.23%] 240,532,859 L1-dcache-loads # 1.215 M/sec [30.73%] 23,151,832 L1-dcache-load-misses # 9.63% of all L1-dcache hits [30.61%] 5,283,803 LLC-loads # 0.027 M/sec [30.60%] 1,079,973 LLC-load-misses # 20.44% of all LL-cache hits [30.60%] 13.434898734 seconds time elapsed - #define FBSTRING_PERVERSE ** gcc-4.8.1-glibc-2.17 $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 I0507 17:37:01.095785 28744 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 2.80ps 357.44G privat_std_1t 118.65% 2.36ps 424.09G static_fbs_1t 0.30% 937.44ps 1.07G privat_fbs_1t 0.30% 924.33ps 1.08G static_sp__1t 229.14% 1.22ps 819.03G privat_sp__1t 212.22% 1.32ps 758.55G static_std_32t 662.00ps 1.51G privat_std_32t 134.15% 493.47ps 2.03G static_fbs_32t 1.27% 52.24ns 19.14M privat_fbs_32t 28.02% 2.36ns 423.31M static_sp__32t 138.51% 477.94ps 2.09G privat_sp__32t 138.39% 478.38ps 2.09G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 316918.699522 task-clock # 17.561 CPUs utilized 8,761 context-switches # 0.028 K/sec 2,190 CPU-migrations # 0.007 K/sec 5,361 page-faults # 0.017 K/sec 683,482,498,044 cycles # 2.157 GHz [25.13%] 488,046,572,692 stalled-cycles-frontend # 71.41% frontend cycles idle [30.18%] 269,765,079,972 stalled-cycles-backend # 39.47% backend cycles idle [30.17%] 756,213,442,723 instructions # 1.11 insns per cycle # 0.65 stalled cycles per insn [25.17%] 175,643,190,326 branches # 554.222 M/sec [30.14%] 3,737,621 branch-misses # 0.00% of all branches [25.63%] 35,169,313,417 L1-dcache-loads # 110.973 M/sec [30.31%] 215,454,174 L1-dcache-load-misses # 0.61% of all L1-dcache hits [30.25%] 148,883,234 LLC-loads # 0.470 M/sec [30.25%] 48,768,585 LLC-load-misses # 32.76% of all LL-cache hits [30.26%] 18.046902132 seconds time elapsed ** AFTER ** - define nothing ** gcc-4.8.1-glibc-2.17-fb $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 I0507 20:34:15.943284 16852 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 936.05ps 1.07G privat_std_1t 100.67% 929.82ps 1.08G static_fbs_1t 98.63% 949.07ps 1.05G privat_fbs_1t 101.56% 921.69ps 1.08G static_sp__1t 40342.12% 2.32ps 430.98G privat_sp__1t 16370.35% 5.72ps 174.89G static_std_32t 409.26ns 2.44M privat_std_32t 16777.41% 2.44ns 409.95M static_fbs_32t 17398.58% 2.35ns 425.13M privat_fbs_32t 17475.47% 2.34ns 427.01M static_sp__32t 85426.96% 479.07ps 2.09G privat_sp__32t 85033.14% 481.29ps 2.08G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 1387268.222731 task-clock # 25.553 CPUs utilized 34,698 context-switches # 0.025 K/sec 2,770 CPU-migrations # 0.002 K/sec 3,039 page-faults # 0.002 K/sec 3,019,637,816,074 cycles # 2.177 GHz [25.21%] 2,801,192,631,479 stalled-cycles-frontend # 92.77% frontend cycles idle [30.02%] 2,020,857,118,698 stalled-cycles-backend # 66.92% backend cycles idle [30.00%] 801,090,224,478 instructions # 0.27 insns per cycle # 3.50 stalled cycles per insn [25.20%] 206,099,842,649 branches # 148.565 M/sec [30.03%] 12,954,936 branch-misses # 0.01% of all branches [25.64%] 104,129,435,254 L1-dcache-loads # 75.061 M/sec [30.07%] 883,390,641 L1-dcache-load-misses # 0.85% of all L1-dcache hits [30.06%] 516,975,218 LLC-loads # 0.373 M/sec [30.04%] 255,887,523 LLC-load-misses # 49.50% of all LL-cache hits [30.04%] 54.289185806 seconds time elapsed - #define FBSTRING_PERVERSE ** gcc-4.8.1-glibc-2.17-fb $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 4.20s experimental/lucian/bench/StringTerminatorBenchmark.cpp Linking _build/opt/experimental/lucian/bench/string_terminator_benchmark... 2.47s _build/opt/experimental/lucian/bench/string_terminator_benchmark I0507 20:19:07.272021 18610 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 936.15ps 1.07G privat_std_1t 100.84% 928.34ps 1.08G static_fbs_1t 97.92% 956.06ps 1.05G privat_fbs_1t 101.41% 923.14ps 1.08G static_sp__1t inf% 0.00fs infinity privat_sp__1t inf% 0.00fs infinity static_std_32t 413.49ns 2.42M privat_std_32t 17375.60% 2.38ns 420.22M static_fbs_32t 17443.07% 2.37ns 421.85M privat_fbs_32t 15354.32% 2.69ns 371.33M static_sp__32t 82034.91% 504.05ps 1.98G privat_sp__32t 63367.22% 652.53ps 1.53G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 1390538.848103 task-clock # 25.373 CPUs utilized 37,417 context-switches # 0.027 K/sec 3,147 CPU-migrations # 0.002 K/sec 2,876 page-faults # 0.002 K/sec 3,024,513,016,946 cycles # 2.175 GHz [25.08%] 2,813,021,108,191 stalled-cycles-frontend # 93.01% frontend cycles idle [30.02%] 2,043,124,392,473 stalled-cycles-backend # 67.55% backend cycles idle [30.01%] 774,663,686,661 instructions # 0.26 insns per cycle # 3.63 stalled cycles per insn [25.09%] 197,666,485,664 branches # 142.151 M/sec [30.03%] 15,077,576 branch-misses # 0.01% of all branches [25.73%] 104,720,369,589 L1-dcache-loads # 75.309 M/sec [30.05%] 886,090,434 L1-dcache-load-misses # 0.85% of all L1-dcache hits [30.04%] 520,015,584 LLC-loads # 0.374 M/sec [30.03%] 256,990,100 LLC-load-misses # 49.42% of all LL-cache hits [30.04%] 54.804099454 seconds time elapsed - #define FBSTRING_CONSERVATIVE ** gcc-4.8.1-glibc-2.17-fb $ perf stat --detailed _build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000 4.02s experimental/lucian/bench/StringTerminatorBenchmark.cpp Linking _build/opt/experimental/lucian/bench/string_terminator_benchmark... 2.45s _build/opt/experimental/lucian/bench/string_terminator_benchmark I0507 20:31:31.120209 10543 StringTerminatorBenchmark.cpp:98] --bm_min_iters=100000000 ============================================================================ experimental/lucian/bench/StringTerminatorBenchmark.cpprelative time/iter iters/s ============================================================================ static_std_1t 929.96ps 1.08G privat_std_1t 100.37% 926.53ps 1.08G static_fbs_1t inf% 0.00fs infinity privat_fbs_1t inf% 0.00fs infinity static_sp__1t inf% 0.00fs infinity privat_sp__1t inf% 0.00fs infinity static_std_32t 381.41ns 2.62M privat_std_32t 16080.74% 2.37ns 421.62M static_fbs_32t 80498.05% 473.81ps 2.11G privat_fbs_32t 80368.84% 474.57ps 2.11G static_sp__32t 80287.07% 475.05ps 2.11G privat_sp__32t 80410.51% 474.33ps 2.11G ============================================================================ Performance counter stats for '_build/opt/experimental/lucian/bench/string_terminator_benchmark --bm_min_iters=100000000': 1293727.223839 task-clock # 25.403 CPUs utilized 33,881 context-switches # 0.026 K/sec 3,718 CPU-migrations # 0.003 K/sec 3,829 page-faults # 0.003 K/sec 2,813,078,184,066 cycles # 2.174 GHz [25.11%] 2,597,561,032,630 stalled-cycles-frontend # 92.34% frontend cycles idle [30.04%] 1,883,652,860,583 stalled-cycles-backend # 66.96% backend cycles idle [30.02%] 800,150,465,648 instructions # 0.28 insns per cycle # 3.25 stalled cycles per insn [25.10%] 197,970,559,157 branches # 153.023 M/sec [30.02%] 15,385,773 branch-misses # 0.01% of all branches [25.95%] 36,541,946,374 L1-dcache-loads # 28.245 M/sec [30.08%] 813,994,917 L1-dcache-load-misses # 2.23% of all L1-dcache hits [30.07%] 467,241,616 LLC-loads # 0.361 M/sec [30.07%] 247,980,582 LLC-load-misses # 53.07% of all LL-cache hits [30.08%] 50.928965545 seconds time elapsed Reviewed By: njormrod@fb.com FB internal diff: D1318048
-
Dave Watson authored
Summary: Folly jenkins build has been failing for a couple days: http://ci-builds.fb.com/job/folly/ Due to a dep on an experimental file in D1307044. Added file to Makefile.am, also needs boost_filesystem, added configure and link check for that too. Test Plan: build works on ubuntu Reviewed By: alandau@fb.com FB internal diff: D1316855
-
Elizabeth Smith authored
Summary: MSVC does not support Expression SFINAE http://stackoverflow.com/questions/12654067 this is a very nice c++11 feature that makes for some nice clean templating But of course MSVC can't have nice things - it partially implements this when it feels like it, so some will work and some will need the nonsense @override-unit-failures There will be more of these little template helper fixes - they make the code a bit more complex but don't actually change anything when compiled The accompanying fix in the test also does nothing but work around an MSVC compiler bug where it loses it's mind over the global namespace Test Plan: fbconfig -r folly && fbmake runtests Reviewed By: delong.j@fb.com FB internal diff: D1312700
-
Marc Celani authored
Summary: A helper function to do try/catch on multiple exception types and store the ressult in an exception_wrapper. The purpose of this function is to best effort mimic std::current_exception(). Unlike std::current_exception(), we need to specify the types that we expect to see. Rather than writing macros or several lines per exception type to capture the exception into an exception_wrapper, this function makes writing try/catch blocks for this purpose very easy. Test Plan: unit test Reviewed By: mhorowitz@fb.com FB internal diff: D1308511 @override-unit-failures
-
Alexey Spiridonov authored
Summary: I got confused by the error message, and wasn't quite clear on the intent of communicateIOBuf() Test Plan: waiting for auto-unittests @override-unit-failures Reviewed By: tudorb@fb.com FB internal diff: D1297525
-
Philip Pronin authored
Summary: Properly handle `this == &other` case. Test Plan: fbconfig -r folly/test && fbmake runtests_opt -j32 Reviewed By: simpkins@fb.com FB internal diff: D1314916
-
Marc Celani authored
Summary: whoops Test Plan: reran unit tests Reviewed By: davejwatson@fb.com Blame Rev:
-
Marc Celani authored
Summary: This diff allows us to use folly::exception_wrapper in ClientReceiveState. Existing use cases are still supported (crs.exception() still returns an exception_ptr no matter what), but we can now choose to set an exception without throwing first. On the folly side, add some new functions for making an exception_ptr from an exception_wrapper. Test Plan: Reran unit tests Reviewed By: davejwatson@fb.com FB internal diff: D1307027 @override-unit-failures
-
Elizabeth Smith authored
Summary: benchmark is necessary to get the tests running primarily replacing a few inline asm items with MSVC intrinsics and do not optimize tricks also a fix for use of the gcc specific ## with __VAR_ARGS__ although that is primarily intended as a workaround for trailing commas, gcc apparently cuts off all items in the macro afterwards this was being used for a clever/dirty trick to do one or none for a macro replaced instead with a version that will work for all other compilers (might need to be expanded for more args, but for now it's working with all current usage) @override-unit-failures also fixed a use of max without specifying a template type that was making msvc barf - specifying it (as in the min case) made it compile cleanly Test Plan: fbconfig -r folly && fbmake runtests Reviewed By: andrei.alexandrescu@fb.com FB internal diff: D1313609
-
Hans Fugal authored
Summary: @mnd wrote some Wangle code that would trip up with a `bad_function_call` exception. This Shouldn't Happen
™ but the exception comes from trying to call a `std::function` which is null. We pretty thoroughly examined his usage and didn't find any problems, and this patch seems to make the error go away. See #4207781 for more details. And reasoning about it, it makes sense. Inline comments explain the race. Test Plan: Alas, I haven't been able to get a minimal repro and therefore a regression unit test. It's a hard race to trigger. I still don't understand why Matt's code does it. Reviewed By: davejwatson@fb.com FB internal diff: D1304001 -
Elizabeth Smith authored
Summary: sal annotations can be used to do similar (not exact) checking to the functionality provided by the format attribute in gcc the annotations are done by prefixing the format string with a value which makes the macro definitions a bit messy @override-unit-failures Test Plan: fbconfig -r folly && fbmake runtests Reviewed By: delong.j@fb.com FB internal diff: D1313653
-
Elizabeth Smith authored
Summary: No need to reinvent the wheel - winpthreads has the appropriate posix layer in place for time functionality and we're already using it for pthreads on windows - so just include the right headers to make sure defines are set up when using time functionality @override-unit-failures Test Plan: fbconfig -r folly && fbmake runtests Reviewed By: delong.j@fb.com FB internal diff: D1313600
-
Elizabeth Smith authored
Summary: msvc puts ssize_t in a stupidly odd place and names it weirdly too this also takes care of snprintf missing (the semantics are slightly off in the msvc version regarding the return value, but usage in folly is limited and does NOT do the double snprintf call madness so this is safe) funcsig and pretty function give you roughtly the same thing in compiler specific implementations strerror_s is msvc's thread save strerror @override-unit-failures Test Plan: fbmake runtests Reviewed By: delong.j@fb.com FB internal diff: D1291542
-
Marc Celani authored
Summary: folly::join should take advantage of StringPiece::size() when joining StringPieces. This avoids unnecessary resizes when appending values to the output string. Test Plan: Reran folly unit tests for strings Reviewed By: philipp@fb.com FB internal diff: D1313009 @override-unit-failures
-
Zejun Wu authored
Summary: Both event_base_new and event_init return nullptr when out of file descriptors. Using null event_base will result in segfault. Test Plan: (ulimit -n 50000 && _build/opt/sigma/service/sigma_server --instance_name=si_sigma_push --min_scribe_log_level=0 --allow_status_port_fallback=true --minloglevel=1 --v=0 --feature_objects_limit=1000000 --hbase_default_timeout_ms=250 --max_total_connections_per_region_server=10 --max_retained_connections_per_region_server=10 --tao_default_timeout_ms=5000 --enable_writes_scribe_si_floop=false --enable_writes_all=false --arena_size_limit=268435456 --run_fxl=true) Reviewed By: davejwatson@fb.com FB internal diff: D1311855
-
Philip Pronin authored
Summary: Some of mount points may not exist (for example, if application is running from chroot and unshare hasn't been used). @override-unit-failures Test Plan: unicorn canary Reviewed By: tudorb@fb.com FB internal diff: D1311374
-
Tudor Bosman authored
Test Plan: folly/test Reviewed By: simpkins@fb.com FB internal diff: D1303911
-
Marc Celani authored
Summary: Comments to discuss motivation Test Plan: its comments Reviewed By: delong.j@fb.com FB internal diff: D1308259 @override-unit-failures
-
Louis Brandy authored
Summary: This was previously in thrift (and copied and pasted in several other places, including folly itself). Other potential open-source projects want this basic functionality so lets centralize it in folly instead of having potentially awkward dependencies on thrift (or copy/paste everywhere). Test Plan: Build all the things. Run the tests. Reviewed By: delong.j@fb.com FB internal diff: D1297972
-
Bryan Alger authored
Summary: ext/random causes issues building on android Test Plan: compiled on fbandroid Reviewed By: bmaurer@fb.com FB internal diff: D1308224
-
Tudor Bosman authored
Summary: Converting from std::exception* to void* to T* (where T is not std::exception but a derived type) is undefined behavior (and will break with multiple or virtual inheritance). Luckily, there's no need for void* there at all. Also, don't force make_exception_wrapper to capture by value. Test Plan: exception_wrapper_test Reviewed By: marccelani@fb.com FB internal diff: D1308251 @override-unit-failures
-
Tudor Bosman authored
Summary: "writable" is now an option to the MemoryMapping constructor. Test Plan: folly/test, thrift/lib/util/test:FrozenUtilTest, others Reviewed By: kma@fb.com FB internal diff: D1307044 @override-unit-failures
-
Dave Watson authored
Summary: As title, add newly added files. fbthrift's jenkins build is failing due to missing futex and lifosem. Added other ones that looked new http://ci-builds.fb.com/job/fbthrift/ Test Plan: Built folly on ubuntu. Builds. Reviewed By: pgriess@fb.com FB internal diff: D1306401
-
Marc Celani authored
Summary: folly::exception_wrapper is a different take on std::exception_ptr to suit a specific use case. The good: std::exception_ptr is not templated, so it can easily be used in different classes without template creep. You can pass errors around between threads or simply between modules. Rethrowing the exception throws the *proper* derived class exception, not some base class. The bad: Getting access to the exception requires throwing, which is expensive. Many users of popular frameworks that take advantage of std::exception_ptr check if the exception is set, and if so do some error handling without actually knowing the type of the exception or logging its message, just to avoid the cost of rethrowing the exception. The ugly: Creating an exception_ptr requires throwing the exception as least once. This is bad in the performance sensitive case where users will not even inspect the exception. This class takes advantage of the good while avoiding the requirement to throw. By using a templated deleter and thrower function, we can create an exception_wrapper which is properly managed, can be thrown, and can be retrieved as a void* with a get() function. Users that previously caught exceptions are now able to dynamically cast to different exception types they formerly caught to avoid the unwind cost while still getting details about the error. Test Plan: unit test Reviewed By: davejwatson@fb.com FB internal diff: D1305470 @override-unit-failures
-
Tudor Bosman authored
Summary: The Chatty subprocess test incorrectly assumed that we saw EOF on the last read from the child (that is, read() returned 0). That's not the case for two reasons: 1. the child is allowed to stall right before it closes its stdout, in which case we get EAGAIN, and 2. Subprocess::communicate would close the fd without calling the read callback anyway. Fix both such things. Test Plan: ran test Reviewed By: njormrod@fb.com FB internal diff: D1303215
-
Dave Watson authored
Summary: Makes a fair comparison between asox queue and notification queue. THe updated benchmark is just noise in this diff, notificationqueue isn't fast enough (yet) to make a difference. Test Plan: fbconfig common/concurrency; fbmake opt ./common/concurrency/QueueBenchmark.sh Reviewed By: afrind@fb.com FB internal diff: D1272859
-
Andrey Goder authored
Summary: We have these helper methods, but are not using them. What sadness. Test Plan: fbconfig -r folly fbmake runtests Reviewed By: tudorb@fb.com FB internal diff: D1299720
-
Peter Griess authored
Summary: - Its methods are being used; include the header @override-unit-failures Test Plan: - Build for iOS Reviewed By: tudorb@fb.com FB internal diff: D1299440
-
Marc Celani authored
Summary: Unless a service is overloaded, it should be able to clear its queue frequently. When this happens, threads fall asleep until more work is available in the queue. Waking up threads in LIFO order gives us a lot of benefits. First, threads that were most recently active are more likely to be mapped to the same cpu core and thereby experience better L1 cache hit rate. Second, we can madvise away jemalloc arenas on very idle threads. If we wake up threads in FIFO order, we will never get a thread to remain idle long enough for this to be worthwhile. folly::LifoSem does just that. Benchmark in which the queue is allowed to drain show that we get a substantial increase in throughput by waking up threads in LIFO order. Test Plan: QueueBenchmark results summary: As expected, benchmarks run faster in the case where the queue is able to frequently drain itself, particularly in cases where the number of threads is large. Benchmarks run slower when the consumers cannot keep up with the producers, particularly when we reach the queue capacity and we need to synchronize between producers and consumers. However, in this case I think we care less about the overhead of the queue itself and more about how quickly we can shed the actual underlying load. Reviewed By: davejwatson@fb.com FB internal diff: D1298343
-
Marcelo Juchem authored
Summary: example results were backwards Test Plan: unit tests Reviewed By: brg@fb.com FB internal diff: D1262425
-
Tudor Bosman authored
Summary: ... as it comes from Elf::getSymbolName, which returns null-terminated C strings. So there's no need to copy it into a fixed-size buffer (and have a buffer overflow, ouch). Test Plan: folly/experimental/symbolizer_test, see what else "arc unit" gets us Reviewed By: tconerly@fb.com FB internal diff: D1286348
-
Tom Jackson authored
Test Plan: unit tests Reviewed By: lucian@fb.com FB internal diff: D1290632
-
Tian Fang authored
Summary: Support addValueAggregated() for histogram to add multiple samples for one bucket at one time. Test Plan: Have a client to call the new API and test in production. Reviewed By: simpkins@fb.com FB internal diff: D1286528
-
