Fix `Array#sample` with `MRB_INT32`

Array index became potentially negative because `uint32_t` is cast to `mrb_int`.

Fix `Array#sample` with `MRB_INT32`
Array index became potentially negative because `uint32_t` is cast to `mrb_int`.
7178a5e7 · KOBAYASHI Shuji · 4aabf91e · 7178a5e7
Commit 7178a5e7 authored Aug 26, 2019 by KOBAYASHI Shuji
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

mrbgems/mruby-random/src/random.c mrbgems/mruby-random/src/random.c +2 -2

No files found.
--- a/mrbgems/mruby-random/src/random.c
+++ b/mrbgems/mruby-random/src/random.c
@@ -317,7 +317,7 @@ mrb_ary_sample(mrb_state *mrb, mrb_value ary)

      for (;;) {
      retry:
-        r = (mrb_int)rand_uint32(random) % len;
+        r = (mrb_int)(rand_uint32(random) % len);

        for (j=0; j<i; j++) {
          if (mrb_fixnum(RARRAY_PTR(result)[j]) == r) {