Commit a9d0d90f authored by Lothar Scholz's avatar Lothar Scholz

Removed the Visual Studio Version Check because it does not

work with internationalized versions of Visual Studio. It will capture
the returned string in the local codepage encoding and make ruby exits
with an invalid UTF8 error message.

Also "Version" might be translated and not appear in the output.
parent 06f90a3b
...@@ -55,14 +55,15 @@ MRuby::Toolchain.new(:visualcpp) do |conf, _params| ...@@ -55,14 +55,15 @@ MRuby::Toolchain.new(:visualcpp) do |conf, _params|
conf.file_separator = '\\' conf.file_separator = '\\'
if require 'open3' # Unreliable detection and will result in invalid encoding errors for localized versions of Visual C++
Open3.popen3 conf.cc.command do |_, _, e, _| # if require 'open3'
if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 # Open3.popen3 conf.cc.command do |_, _, e, _|
m = "# VS2010/2012 support will be dropped after the next release! #" # if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17
h = "#" * m.length # m = "# VS2010/2012 support will be dropped after the next release! #"
puts h, m, h # h = "#" * m.length
end # puts h, m, h
end # end
end # end
# end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment