lshift must not assume sizeof(long) >= sizeof(mrb_int)

ac3b1c4c · Yukihiro Matsumoto · 19cd9c6e · ac3b1c4c
Commit ac3b1c4c authored Oct 19, 2012 by Yukihiro Matsumoto
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

src/numeric.c src/numeric.c +1 -2

No files found.
--- a/src/numeric.c
+++ b/src/numeric.c
@@ -949,8 +949,7 @@ fix_xor(mrb_state *mrb, mrb_value x)
 static mrb_value
 lshift(mrb_state *mrb, mrb_int val, unsigned long width)
 {
-  if (width > (sizeof(mrb_int)*CHAR_BIT-1)
+  if (width > (sizeof(mrb_int)*CHAR_BIT-1)) {
-      || ((unsigned long)abs(val))>>(sizeof(mrb_int)*CHAR_BIT-1-width) > 0) {
      mrb_raise(mrb, E_RANGE_ERROR, "width(%d) > (%d:sizeof(mrb_int)*CHAR_BIT-1)", width,
 		sizeof(mrb_int)*CHAR_BIT-1);
  }