Skip to content

N
nghttp2
Commit 08fea570 authored by Tatsuhiro Tsujikawa's avatar Tatsuhiro Tsujikawa
Browse files
Options

python: Fix bug that settings timer is started when SETTINGS with ACK is sent

parent 8e5b5d00
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
python/nghttp2.pyx
View file @ 08fea570
...@@ -456,7 +456,7 @@ cdef int server_on_frame_send(cnghttp2.nghttp2_session *session, ...@@ -456,7 +456,7 @@ cdef int server_on_frame_send(cnghttp2.nghttp2_session *session,
http2.send_response(handler) http2.send_response(handler)
elif frame.hd.type == cnghttp2.NGHTTP2_SETTINGS: elif frame.hd.type == cnghttp2.NGHTTP2_SETTINGS:
if (frame.hd.flags & cnghttp2.NGHTTP2_FLAG_ACK) == 0: if (frame.hd.flags & cnghttp2.NGHTTP2_FLAG_ACK) != 0:
return 0 return 0
http2._start_settings_timer() http2._start_settings_timer()
...@@ -606,7 +606,7 @@ cdef int client_on_frame_send(cnghttp2.nghttp2_session *session, ...@@ -606,7 +606,7 @@ cdef int client_on_frame_send(cnghttp2.nghttp2_session *session,
logging.debug('client_on_frame_send, type:%s, stream_id:%s', frame.hd.type, frame.hd.stream_id) logging.debug('client_on_frame_send, type:%s, stream_id:%s', frame.hd.type, frame.hd.stream_id)
if frame.hd.type == cnghttp2.NGHTTP2_SETTINGS: if frame.hd.type == cnghttp2.NGHTTP2_SETTINGS:
if (frame.hd.flags & cnghttp2.NGHTTP2_FLAG_ACK) == 0: if (frame.hd.flags & cnghttp2.NGHTTP2_FLAG_ACK) != 0:
return 0 return 0
http2._start_settings_timer() http2._start_settings_timer()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment