Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
N
nghttp2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
nghttp2
Commits
2cff8b43
Commit
2cff8b43
authored
Apr 15, 2019
by
Tatsuhiro Tsujikawa
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
nghttpx: Fix bug that chunked request stalls
parent
ce962c3f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
4 deletions
+10
-4
src/shrpx_http_downstream_connection.cc
src/shrpx_http_downstream_connection.cc
+9
-4
src/shrpx_http_downstream_connection.h
src/shrpx_http_downstream_connection.h
+1
-0
No files found.
src/shrpx_http_downstream_connection.cc
View file @
2cff8b43
...
@@ -696,8 +696,9 @@ int HttpDownstreamConnection::process_blocked_request_buf() {
...
@@ -696,8 +696,9 @@ int HttpDownstreamConnection::process_blocked_request_buf() {
}
}
}
}
if
(
downstream_
->
get_blocked_request_data_eof
())
{
if
(
downstream_
->
get_blocked_request_data_eof
()
&&
return
end_upload_data
();
downstream_
->
get_chunked_request
())
{
end_upload_data_chunk
();
}
}
return
0
;
return
0
;
...
@@ -751,6 +752,12 @@ int HttpDownstreamConnection::end_upload_data() {
...
@@ -751,6 +752,12 @@ int HttpDownstreamConnection::end_upload_data() {
return
0
;
return
0
;
}
}
end_upload_data_chunk
();
return
0
;
}
void
HttpDownstreamConnection
::
end_upload_data_chunk
()
{
const
auto
&
req
=
downstream_
->
request
();
const
auto
&
req
=
downstream_
->
request
();
auto
output
=
downstream_
->
get_request_buf
();
auto
output
=
downstream_
->
get_request_buf
();
...
@@ -763,8 +770,6 @@ int HttpDownstreamConnection::end_upload_data() {
...
@@ -763,8 +770,6 @@ int HttpDownstreamConnection::end_upload_data() {
http2
::
HDOP_STRIP_ALL
);
http2
::
HDOP_STRIP_ALL
);
output
->
append
(
"
\r\n
"
);
output
->
append
(
"
\r\n
"
);
}
}
return
0
;
}
}
namespace
{
namespace
{
...
...
src/shrpx_http_downstream_connection.h
View file @
2cff8b43
...
@@ -53,6 +53,7 @@ public:
...
@@ -53,6 +53,7 @@ public:
virtual
int
push_request_headers
();
virtual
int
push_request_headers
();
virtual
int
push_upload_data_chunk
(
const
uint8_t
*
data
,
size_t
datalen
);
virtual
int
push_upload_data_chunk
(
const
uint8_t
*
data
,
size_t
datalen
);
virtual
int
end_upload_data
();
virtual
int
end_upload_data
();
void
end_upload_data_chunk
();
virtual
void
pause_read
(
IOCtrlReason
reason
);
virtual
void
pause_read
(
IOCtrlReason
reason
);
virtual
int
resume_read
(
IOCtrlReason
reason
,
size_t
consumed
);
virtual
int
resume_read
(
IOCtrlReason
reason
,
size_t
consumed
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment