nghttpx: Handle c-ares success without result

55ecb082 · Tatsuhiro Tsujikawa · 3933280d · 55ecb082
Commit 55ecb082 authored Jan 03, 2017 by Tatsuhiro Tsujikawa
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

src/shrpx_dns_resolver.cc src/shrpx_dns_resolver.cc +7 -1

No files found.
--- a/src/shrpx_dns_resolver.cc
+++ b/src/shrpx_dns_resolver.cc
@@ -298,7 +298,13 @@ void DNSResolver::on_result(int status, hostent *hostent) {
  }
  auto ap = *hostent->h_addr_list;
-  assert(ap);
+  if (!ap) {
+    if (LOG_ENABLED(INFO)) {
+      LOG(INFO) << "Name lookup for " << name_ << "failed: no address returned";
+    }
+    status_ = DNS_STATUS_ERROR;
+    return;
+  }
  switch (hostent->h_addrtype) {
  case AF_INET: