nghttpx: It is enough to check "chunked" in the suffix

src/shrpx_downstream.cc

@@ -662,7 +662,7 @@ void Downstream::inspect_http1_request() {
   auto transfer_encoding = req_.fs.header(http2::HD_TRANSFER_ENCODING);
   if (transfer_encoding) {
     req_.fs.content_length = -1;
-    if (util::strifind(transfer_encoding->value.c_str(), "chunked")) {
+    if (util::iends_with_l(transfer_encoding->value, "chunked")) {
       chunked_request_ = true;
     }
   }
@@ -672,7 +672,7 @@ void Downstream::inspect_http1_response() {
   auto transfer_encoding = resp_.fs.header(http2::HD_TRANSFER_ENCODING);
   if (transfer_encoding) {
     resp_.fs.content_length = -1;
-    if (util::strifind(transfer_encoding->value.c_str(), "chunked")) {
+    if (util::iends_with_l(transfer_encoding->value, "chunked")) {
       chunked_response_ = true;
     }
   }

src/util.h

@@ -238,6 +238,10 @@ inline bool iends_with(const std::string &a, const std::string &b) {
   return iends_with(std::begin(a), std::end(a), std::begin(b), std::end(b));
 }
 
+template <size_t N> bool iends_with_l(const std::string &a, const char(&b)[N]) {
+  return iends_with(std::begin(a), std::end(a), b, b + N - 1);
+}
+
 int strcompare(const char *a, const uint8_t *b, size_t n);
 
 template <typename InputIt> bool strieq(const char *a, InputIt b, size_t bn) {

src/util_test.cc

@@ -374,6 +374,9 @@ void test_util_ends_with(void) {
   CU_ASSERT(util::iends_with("foo", ""));
   CU_ASSERT(util::iends_with("oFoo", "fOO"));
   CU_ASSERT(!util::iends_with("ofoo", "fo"));
+
+  CU_ASSERT(util::iends_with_l("oFoo", "fOO"));
+  CU_ASSERT(!util::iends_with_l("ofoo", "fo"));
 }
 
 void test_util_parse_http_date(void) {