UE authentication procedure improvements

src/ue/nas/usim/sqn_mng.cpp

@@ -35,15 +35,10 @@ uint64_t SqnManager::getIndFromSqn(uint64_t sqn) const
 
 uint64_t SqnManager::getSeqMs() const
 {
-    return getSeqFromSqn(getSqnValue());
+    return getSeqFromSqn(getSqnMs());
 }
 
-uint64_t &SqnManager::getSqnRef()
-{
-    return *std::max_element(m_sqnArr.begin(), m_sqnArr.end());
-}
-
-uint64_t SqnManager::getSqnValue() const
+uint64_t SqnManager::getSqnMs() const
 {
     return *std::max_element(m_sqnArr.begin(), m_sqnArr.end());
 }
@@ -72,7 +67,7 @@ bool SqnManager::checkSqn(const OctetString &sqn)
 
 OctetString SqnManager::getSqn() const
 {
-    return OctetString::FromOctet8(getSqnValue()).subCopy(2);
+    return OctetString::FromOctet8(getSqnMs()).subCopy(2);
 }
 
 } // namespace nr::ue

src/ue/nas/usim/sqn_mng.hpp

@@ -32,8 +32,7 @@ class SqnManager
     [[nodiscard]] uint64_t getSeqFromSqn(uint64_t sqn) const;
     [[nodiscard]] uint64_t getIndFromSqn(uint64_t sqn) const;
     [[nodiscard]] uint64_t getSeqMs() const;
-    [[nodiscard]] uint64_t &getSqnRef();
-    [[nodiscard]] uint64_t getSqnValue() const;
+    [[nodiscard]] uint64_t getSqnMs() const;
     bool checkSqn(uint64_t sqn);
 
   public: