UE: review and annotate code with FIXME

openair3/NAS/UE/API/USER/at_command.c

@@ -54,6 +54,7 @@ Description Defines the ATtention (AT) command set supported by the NAS
 /****************  E X T E R N A L    D E F I N I T I O N S  ****************/
 /****************************************************************************/
 
+// FIXME Put this in .h
 extern int at_response_format_v1;
 extern int at_error_code_suppression_q1;
 extern at_error_format_t at_error_format;
@@ -278,6 +279,7 @@ int at_command_decode(const char* buffer, int length, at_command_t* at_command)
   char* buf = strdup(buffer+2);
   char* cmd = strtok(buf, ";");
 
+  // FIXME check overflow
   for (i=0; cmd && (rc != RETURNerror); i++) {
     rc = ParseString(cmd, &at_command[i]);
     cmd = strtok(NULL, ";");

openair3/NAS/UE/API/USER/at_error.c

@@ -49,6 +49,7 @@ Description Defines error codes returned when execution of AT command
 /****************  E X T E R N A L    D E F I N I T I O N S  ****************/
 /****************************************************************************/
 
+// FIXME put this in .h
 extern int at_response_format_v1;
 
 /*

openair3/NAS/UE/EMM/SAP/EmmDeregistered.c

@@ -97,7 +97,6 @@ int EmmDeregistered(nas_user_t *user, const emm_reg_t *evt)
 
 
   /* Delete the authentication data RAND and RES */
-  // FIXME REVIEW
   rc = emm_proc_authentication_delete(user);
 
   if (rc != RETURNok) {

openair3/NAS/UE/EMM/emm_proc.h

@@ -107,7 +107,6 @@ int emm_proc_attach_release(void *args);
 int emm_proc_attach_restart(nas_user_t *user);
 
 int emm_proc_attach_set_emergency(emm_data_t *emm_data);
-// FIXME check prototype
 int emm_proc_attach_set_detach(void *user);
 
 

openair3/NAS/UE/ESM/esmData.h

@@ -204,6 +204,7 @@ typedef esm_data_context_t esm_data_t;
 /******************  E X P O R T E D    F U N C T I O N S  ******************/
 /****************************************************************************/
 
+// FIXME prototype and buffer allocation
 extern char ip_addr_str[100];
 
 extern char *esm_data_get_ipv4_addr(const OctetString *ip_addr);

openair3/NAS/UE/ESM/esm_ip.c

@@ -25,6 +25,7 @@
 // FIXME don't work for reentrant calls
 char ip_addr_str[100];
 
+// FIXME can't be extern and inline at same time !
 inline char *esm_data_get_ipv4_addr(const OctetString *ip_addr)
 {
   if (ip_addr->length > 0) {

openair3/NAS/UE/nas_ue_task.c

@@ -33,8 +33,10 @@
 
 #include "nas_user.h"
 
+// FIXME make command line option for NAS_UE_AUTOSTART
 # define NAS_UE_AUTOSTART 1
 
+// FIXME review these externs
 extern unsigned char NB_eNB_INST;
 extern unsigned char NB_UE_INST;