addressing a couple of review comments

openair2/LAYER2/NR_MAC_UE/nr_ra_procedures.c

@@ -488,7 +488,8 @@ void ra_preambles_config(NR_PRACH_RESOURCES_t *prach_resources, NR_UE_MAC_INST_t
     // Overwrite seed with non-random seed for IQ player/recorder
     seed = 1;
   } else {
-    seed=(unsigned int) (rdtsc_oai() & ~0);
+    // & to truncate the int64_t and keep only the LSB bits, up to sizeof(int)
+    seed = (unsigned int) (rdtsc_oai() & ~0);
   }
 
   RA_config_t *ra = &mac->ra;
@@ -1038,7 +1039,8 @@ void nr_ra_failed(uint8_t mod_id, uint8_t CC_id, NR_PRACH_RESOURCES_t *prach_res
     // Overwrite seed with non-random seed for IQ player/recorder
     seed = 1;
   } else {
-    seed=(unsigned int) (rdtsc_oai() & ~0);
+    // & to truncate the int64_t and keep only the LSB bits, up to sizeof(int)
+    seed = (unsigned int) (rdtsc_oai() & ~0);
   }
   
   ra->first_Msg3 = 1;

openair3/NGAP/ngap_gNB_nas_procedures.c

@@ -693,6 +693,7 @@ int ngap_gNB_initial_ctxt_resp(instance_t instance, ngap_initial_context_setup_r
 
         case NGAP_CAUSE_NOTHING:
         default:
+          LOG_E(NR_RRC, "Unknown PDU session failure cause %d\n", initial_ctxt_resp_p->pdusessions_failed[i].cause);
           break;
       }
 
@@ -960,6 +961,7 @@ int ngap_gNB_pdusession_setup_resp(instance_t instance, ngap_pdusession_setup_re
 
         case NGAP_CAUSE_NOTHING:
         default:
+          LOG_E(NR_RRC, "Unknown PDU session failure cause %d\n", pdusession_failed->cause);
           break;
       }
       NGAP_DEBUG("pdusession setup response: failed pdusession ID %ld\n", item->pDUSessionID);
@@ -1123,6 +1125,7 @@ int ngap_gNB_pdusession_modify_resp(instance_t instance, ngap_pdusession_modify_
 
       case NGAP_CAUSE_NOTHING:
       default:
+        LOG_E(NR_RRC, "Unknown PDU session failure cause %d\n", pdusession_modify_resp_p->pdusessions_failed[i].cause);
         break;
       }
 

radio/iqplayer/iqplayer_lib.c

@@ -48,8 +48,6 @@ static void busy_wait(uint32_t usecs) {
   // Active wait
   clock_gettime(CLOCK_REALTIME, &requestStart);
   while (1) {
-    for (int j=0; j < 40; j++)
-      (void) sin(j);
     clock_gettime(CLOCK_REALTIME, &requestEnd);
     elapsed_usecs = ( requestEnd.tv_sec - requestStart.tv_sec ) / 1e-6
       + ( requestEnd.tv_nsec - requestStart.tv_nsec ) / 1e3;