Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
O
OpenXG UE
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenXG
OpenXG UE
Commits
bf5e726f
Commit
bf5e726f
authored
May 17, 2021
by
hardy
Browse files
Options
Browse Files
Download
Plain Diff
Merge remote-tracking branch 'origin/physim-deploy-handle-error-cases' into integration_2021_wk20_a
parents
e6edb2ae
04adce6b
Changes
10
Show whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
275 additions
and
217 deletions
+275
-217
ci-scripts/cls_containerize.py
ci-scripts/cls_containerize.py
+2
-2
ci-scripts/cls_oaicitest.py
ci-scripts/cls_oaicitest.py
+2
-2
ci-scripts/cls_physim.py
ci-scripts/cls_physim.py
+191
-191
ci-scripts/cls_physim1.py
ci-scripts/cls_physim1.py
+59
-17
ci-scripts/cls_static_code_analysis.py
ci-scripts/cls_static_code_analysis.py
+2
-2
ci-scripts/constants.py
ci-scripts/constants.py
+5
-0
ci-scripts/html.py
ci-scripts/html.py
+10
-0
ci-scripts/main.py
ci-scripts/main.py
+1
-1
ci-scripts/ran.py
ci-scripts/ran.py
+2
-2
ci-scripts/xml_files/container_image_build.xml
ci-scripts/xml_files/container_image_build.xml
+1
-0
No files found.
ci-scripts/cls_containerize.py
View file @
bf5e726f
...
...
@@ -162,7 +162,7 @@ class Containerize():
# on RedHat/CentOS .git extension is mandatory
result
=
re
.
search
(
'([a-zA-Z0-9\:\-\.\/])+\.git'
,
self
.
ranRepository
)
if
result
is
not
None
:
full_ran_repo_name
=
self
.
ranRepository
full_ran_repo_name
=
self
.
ranRepository
.
replace
(
'git/'
,
'git'
)
else
:
full_ran_repo_name
=
self
.
ranRepository
+
'.git'
mySSH
.
command
(
'mkdir -p '
+
lSourcePath
,
'\$'
,
5
)
...
...
@@ -176,7 +176,7 @@ class Containerize():
mySSH
.
command
(
'mkdir -p cmake_targets/log'
,
'\$'
,
5
)
# if the commit ID is provided use it to point to it
if
self
.
ranCommitID
!=
''
:
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
5
)
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
30
)
# if the branch is not develop, then it is a merge request and we need to do
# the potential merge. Note that merge conflicts should already been checked earlier
imageTag
=
'develop'
...
...
ci-scripts/cls_oaicitest.py
View file @
bf5e726f
...
...
@@ -177,7 +177,7 @@ class OaiCiTest():
ue_prefix
=
''
result
=
re
.
search
(
'([a-zA-Z0-9\:\-\.\/])+\.git'
,
self
.
ranRepository
)
if
result
is
not
None
:
full_ran_repo_name
=
self
.
ranRepository
full_ran_repo_name
=
self
.
ranRepository
.
replace
(
'git/'
,
'git'
)
else
:
full_ran_repo_name
=
self
.
ranRepository
+
'.git'
SSH
.
command
(
'mkdir -p '
+
self
.
UESourceCodePath
,
'\$'
,
5
)
...
...
@@ -220,7 +220,7 @@ class OaiCiTest():
# if the commit ID is provided use it to point to it
if
self
.
ranCommitID
!=
''
:
SSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
5
)
SSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
30
)
# if the branch is not develop, then it is a merge request and we need to do
# the potential merge. Note that merge conflicts should already been checked earlier
if
self
.
ranAllowMerge
:
...
...
ci-scripts/cls_physim.py
View file @
bf5e726f
...
...
@@ -148,7 +148,7 @@ class PhySim:
# if the commit ID is provided, use it to point to it
if
self
.
ranCommitID
!=
''
:
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
5
)
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
30
)
# if the branch is not develop, then it is a merge request and we need to do
# the potential merge. Note that merge conflicts should have already been checked earlier
if
(
self
.
ranAllowMerge
):
...
...
ci-scripts/cls_physim1.py
View file @
bf5e726f
...
...
@@ -64,7 +64,7 @@ class PhySim:
#PUBLIC Methods$
#-----------------$
def
Deploy_PhySim
(
self
,
HTML
):
def
Deploy_PhySim
(
self
,
HTML
,
RAN
):
if
self
.
ranRepository
==
''
or
self
.
ranBranch
==
''
or
self
.
ranCommitID
==
''
:
HELP
.
GenericHelp
(
CONST
.
Version
)
sys
.
exit
(
'Insufficient Parameter'
)
...
...
@@ -88,9 +88,10 @@ class PhySim:
# on RedHat/CentOS .git extension is mandatory
result
=
re
.
search
(
'([a-zA-Z0-9\:\-\.\/])+\.git'
,
self
.
ranRepository
)
if
result
is
not
None
:
full_ran_repo_name
=
self
.
ranRepository
full_ran_repo_name
=
self
.
ranRepository
.
replace
(
'git/'
,
'git'
)
else
:
full_ran_repo_name
=
self
.
ranRepository
+
'.git'
mySSH
.
command
(
'echo '
+
lPassWord
+
' | sudo rm -Rf '
+
lSourcePath
,
'\$'
,
30
)
mySSH
.
command
(
'mkdir -p '
+
lSourcePath
,
'\$'
,
5
)
mySSH
.
command
(
'cd '
+
lSourcePath
,
'\$'
,
5
)
mySSH
.
command
(
'if [ ! -e .git ]; then stdbuf -o0 git clone '
+
full_ran_repo_name
+
' .; else stdbuf -o0 git fetch --prune; fi'
,
'\$'
,
600
)
...
...
@@ -102,9 +103,15 @@ class PhySim:
mySSH
.
command
(
'mkdir -p cmake_targets/log'
,
'\$'
,
5
)
# if the commit ID is provided use it to point to it
if
self
.
ranCommitID
!=
''
:
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
5
)
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
30
)
if
self
.
ranAllowMerge
:
imageTag
=
"ci-temp"
if
self
.
ranTargetBranch
==
''
:
if
(
self
.
ranBranch
!=
'develop'
)
and
(
self
.
ranBranch
!=
'origin/develop'
):
mySSH
.
command
(
'git merge --ff origin/develop -m "Temporary merge for CI"'
,
'\$'
,
5
)
else
:
logging
.
debug
(
'Merging with the target branch: '
+
self
.
ranTargetBranch
)
mySSH
.
command
(
'git merge --ff origin/'
+
self
.
ranTargetBranch
+
' -m "Temporary merge for CI"'
,
'\$'
,
5
)
else
:
imageTag
=
"develop"
# Check if image is exist on the Red Hat server, before pushing it to OC cluster
...
...
@@ -112,7 +119,9 @@ class PhySim:
if
mySSH
.
getBefore
().
count
(
'no such image'
)
!=
0
:
logging
.
error
(
'
\u001B
[1m No such image oai-physim
\u001B
[0m'
)
mySSH
.
close
()
sys
.
exit
(
-
1
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
PHYSIM_IMAGE_ABSENT
)
RAN
.
prematureExit
=
True
return
else
:
result
=
re
.
search
(
'Size *= *(?P<size>[0-9\-]+) *bytes'
,
mySSH
.
getBefore
())
if
result
is
not
None
:
...
...
@@ -135,14 +144,18 @@ class PhySim:
if
mySSH
.
getBefore
().
count
(
'Login successful.'
)
==
0
:
logging
.
error
(
'
\u001B
[1m OC Cluster Login Failed
\u001B
[0m'
)
mySSH
.
close
()
sys
.
exit
(
-
1
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
OC_LOGIN_FAIL
)
RAN
.
prematureExit
=
True
return
else
:
logging
.
debug
(
'
\u001B
[1m Login to OC Cluster Successfully
\u001B
[0m'
)
mySSH
.
command
(
f'oc project
{
ocProjectName
}
'
,
'\$'
,
6
)
if
mySSH
.
getBefore
().
count
(
f'Already on project "
{
ocProjectName
}
"'
)
==
0
and
mySSH
.
getBefore
().
count
(
f'Now using project "
{
self
.
OCProjectName
}
"'
)
==
0
:
logging
.
error
(
f'
\u001B
[1m Unable to access OC project
{
ocProjectName
}
\u001B
[0m'
)
mySSH
.
close
()
sys
.
exit
(
-
1
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
OC_PROJECT_FAIL
)
RAN
.
prematureExit
=
True
return
else
:
logging
.
debug
(
f'
\u001B
[1m Now using project
{
ocProjectName
}
\u001B
[0m'
)
...
...
@@ -151,7 +164,9 @@ class PhySim:
if
mySSH
.
getBefore
().
count
(
'Login Succeeded!'
)
==
0
:
logging
.
error
(
'
\u001B
[1m Podman Login to OC Cluster Registry Failed
\u001B
[0m'
)
mySSH
.
close
()
sys
.
exit
(
-
1
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
OC_LOGIN_FAIL
)
RAN
.
prematureExit
=
True
return
else
:
logging
.
debug
(
'
\u001B
[1m Podman Login to OC Cluster Registry Successfully
\u001B
[0m'
)
time
.
sleep
(
2
)
...
...
@@ -159,7 +174,9 @@ class PhySim:
if
mySSH
.
getBefore
().
count
(
'(AlreadyExists):'
)
==
0
and
mySSH
.
getBefore
().
count
(
'created'
)
==
0
:
logging
.
error
(
f'
\u001B
[1m Image Stream "oai-physim" Creation Failed on OC Cluster
{
ocProjectName
}
\u001B
[0m'
)
mySSH
.
close
()
sys
.
exit
(
-
1
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
OC_IS_FAIL
)
RAN
.
prematureExit
=
True
return
else
:
logging
.
debug
(
f'
\u001B
[1m Image Stream "oai-physim" created on OC project
{
ocProjectName
}
\u001B
[0m'
)
time
.
sleep
(
2
)
...
...
@@ -169,7 +186,9 @@ class PhySim:
if
mySSH
.
getBefore
().
count
(
'Storing signatures'
)
==
0
:
logging
.
error
(
'
\u001B
[1m Image "oai-physim" push to OC Cluster Registry Failed
\u001B
[0m'
)
mySSH
.
close
()
sys
.
exit
(
-
1
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
OC_IS_FAIL
)
RAN
.
prematureExit
=
True
return
else
:
logging
.
debug
(
'
\u001B
[1m Image "oai-physim" push to OC Cluster Registry Successfully
\u001B
[0m'
)
...
...
@@ -180,9 +199,18 @@ class PhySim:
if
mySSH
.
getBefore
().
count
(
'STATUS: deployed'
)
==
0
:
logging
.
error
(
'
\u001B
[1m Deploying PhySim Failed using helm chart on OC Cluster
\u001B
[0m'
)
mySSH
.
command
(
'helm uninstall physim >> cmake_targets/log/physim_helm_summary.txt 2>&1'
,
'\$'
,
6
)
isFinished1
=
False
while
(
isFinished1
==
False
):
time
.
sleep
(
20
)
mySSH
.
command
(
'oc get pods -l app.kubernetes.io/instance=physim'
,
'\$'
,
6
,
resync
=
True
)
if
re
.
search
(
'No resources found'
,
mySSH
.
getBefore
()):
isFinished1
=
True
mySSH
.
command
(
f'sudo podman rmi default-route-openshift-image-registry.apps.5glab.nsa.eurecom.fr/
{
self
.
OCProjectName
}
/oai-physim:
{
imageTag
}
'
,
'\$'
,
6
)
mySSH
.
command
(
'oc delete is oai-physim'
,
'\$'
,
6
)
mySSH
.
close
()
self
.
AnalyzeLogFile_phySim
(
HTML
)
sys
.
exit
(
-
1
)
RAN
.
prematureExit
=
True
return
else
:
logging
.
debug
(
'
\u001B
[1m Deployed PhySim Successfully using helm chart
\u001B
[0m'
)
isRunning
=
False
...
...
@@ -200,7 +228,18 @@ class PhySim:
mySSH
.
command
(
'oc get pods -l app.kubernetes.io/instance=physim 2>&1 | tee -a cmake_targets/log/physim_pods_summary.txt'
,
'\$'
,
6
)
mySSH
.
command
(
'helm uninstall physim >> cmake_targets/log/physim_helm_summary.txt 2>&1'
,
'\$'
,
6
)
self
.
AnalyzeLogFile_phySim
(
HTML
)
sys
.
exit
(
-
1
)
isFinished1
=
False
while
(
isFinished1
==
False
):
time
.
sleep
(
20
)
mySSH
.
command
(
'oc get pods -l app.kubernetes.io/instance=physim'
,
'\$'
,
6
,
resync
=
True
)
if
re
.
search
(
'No resources found'
,
mySSH
.
getBefore
()):
isFinished1
=
True
mySSH
.
command
(
f'sudo podman rmi default-route-openshift-image-registry.apps.5glab.nsa.eurecom.fr/
{
self
.
OCProjectName
}
/oai-physim:
{
imageTag
}
'
,
'\$'
,
6
)
mySSH
.
command
(
'oc delete is oai-physim'
,
'\$'
,
6
)
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
OC_PHYSIM_DEPLOY_FAIL
)
HTML
.
CreateHtmlTestRowPhySimTestResult
(
self
.
testSummary
,
self
.
testResult
)
RAN
.
prematureExit
=
True
return
# Waiting to complete the running test
count
=
0
isFinished
=
False
...
...
@@ -240,8 +279,15 @@ class PhySim:
mySSH
.
command
(
'oc logout'
,
'\$'
,
6
)
mySSH
.
close
()
self
.
AnalyzeLogFile_phySim
(
HTML
)
if
self
.
testStatus
==
False
:
sys
.
exit
(
-
1
)
if
self
.
testStatus
:
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'OK'
,
CONST
.
ALL_PROCESSES_OK
)
HTML
.
CreateHtmlTestRowPhySimTestResult
(
self
.
testSummary
,
self
.
testResult
)
logging
.
info
(
'
\u001B
[1m Physical Simulator Pass
\u001B
[0m'
)
else
:
RAN
.
prematureExit
=
True
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'KO'
,
CONST
.
ALL_PROCESSES_OK
)
HTML
.
CreateHtmlTestRowPhySimTestResult
(
self
.
testSummary
,
self
.
testResult
)
logging
.
info
(
'
\u001B
[1m Physical Simulator Fail
\u001B
[0m'
)
def
AnalyzeLogFile_phySim
(
self
,
HTML
):
lIpAddr
=
self
.
eNBIPAddress
...
...
@@ -258,7 +304,6 @@ class PhySim:
os
.
mkdir
(
f'./physim_test_logs_
{
self
.
testCase_id
}
'
)
mySSH
.
copyin
(
lIpAddr
,
lUserName
,
lPassWord
,
lSourcePath
+
'/cmake_targets/physim_test_log_'
+
self
.
testCase_id
+
'/*'
,
'./physim_test_logs_'
+
self
.
testCase_id
)
mySSH
.
command
(
'rm -rf ./physim_test_log_'
+
self
.
testCase_id
,
'\$'
,
5
)
mySSH
.
command
(
'oc logout'
,
'\$'
,
6
)
mySSH
.
close
()
# physim test log analysis
nextt
=
0
...
...
@@ -289,7 +334,4 @@ class PhySim:
self
.
testSummary
[
'Nbfail'
]
=
self
.
testCount
[
2
]
if
self
.
testSummary
[
'Nbfail'
]
==
0
:
self
.
testStatus
=
True
HTML
.
CreateHtmlTestRow
(
'N/A'
,
'OK'
,
CONST
.
ALL_PROCESSES_OK
)
HTML
.
CreateHtmlTestRowPhySimTestResult
(
self
.
testSummary
,
self
.
testResult
)
logging
.
info
(
'
\u001B
[1m Physical Simulator Pass
\u001B
[0m'
)
return
0
ci-scripts/cls_static_code_analysis.py
View file @
bf5e726f
...
...
@@ -101,7 +101,7 @@ class StaticCodeAnalysis():
# on RedHat/CentOS .git extension is mandatory
result
=
re
.
search
(
'([a-zA-Z0-9\:\-\.\/])+\.git'
,
self
.
ranRepository
)
if
result
is
not
None
:
full_ran_repo_name
=
self
.
ranRepository
full_ran_repo_name
=
self
.
ranRepository
.
replace
(
'git/'
,
'git'
)
else
:
full_ran_repo_name
=
self
.
ranRepository
+
'.git'
mySSH
.
command
(
'mkdir -p '
+
lSourcePath
,
'\$'
,
5
)
...
...
@@ -115,7 +115,7 @@ class StaticCodeAnalysis():
mySSH
.
command
(
'mkdir -p cmake_targets/log'
,
'\$'
,
5
)
# if the commit ID is provided use it to point to it
if
self
.
ranCommitID
!=
''
:
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
5
)
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
30
)
mySSH
.
command
(
'docker image rm oai-cppcheck:bionic oai-cppcheck:xenial || true'
,
'\$'
,
60
)
mySSH
.
command
(
'docker build --tag oai-cppcheck:xenial --file ci-scripts/docker/Dockerfile.cppcheck.xenial . > cmake_targets/log/cppcheck-xenial.txt 2>&1'
,
'\$'
,
600
)
...
...
ci-scripts/constants.py
View file @
bf5e726f
...
...
@@ -60,6 +60,11 @@ OAI_UE_PROCESS_SEG_FAULT = -25
OAI_UE_PROCESS_NO_MBMS_MSGS
=
-
26
OAI_UE_PROCESS_OK
=
+
6
INVALID_PARAMETER
=
-
50
PHYSIM_IMAGE_ABSENT
=
-
60
OC_LOGIN_FAIL
=
-
61
OC_PROJECT_FAIL
=
-
62
OC_IS_FAIL
=
-
63
OC_PHYSIM_DEPLOY_FAIL
=
-
64
UE_STATUS_DETACHED
=
0
UE_STATUS_DETACHING
=
1
...
...
ci-scripts/html.py
View file @
bf5e726f
...
...
@@ -365,6 +365,16 @@ class HTMLManagement():
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - SPGW process not found</td>
\n
'
)
elif
(
processesStatus
==
CONST
.
UE_IP_ADDRESS_ISSUE
):
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - Could not retrieve UE IP address</td>
\n
'
)
elif
(
processesStatus
==
CONST
.
PHYSIM_IMAGE_ABSENT
):
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - No such image oai-physim</td>
\n
'
)
elif
(
processesStatus
==
CONST
.
OC_LOGIN_FAIL
):
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - Could not log onto cluster</td>
\n
'
)
elif
(
processesStatus
==
CONST
.
OC_PROJECT_FAIL
):
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - Could not register into cluster project</td>
\n
'
)
elif
(
processesStatus
==
CONST
.
OC_IS_FAIL
):
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - Could not create Image Stream</td>
\n
'
)
elif
(
processesStatus
==
CONST
.
OC_PHYSIM_DEPLOY_FAIL
):
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >KO - Could not properly deploy physim on cluster</td>
\n
'
)
else
:
self
.
htmlFile
.
write
(
' <td bgcolor = "lightcoral" >'
+
str
(
status
)
+
'</td>
\n
'
)
else
:
...
...
ci-scripts/main.py
View file @
bf5e726f
...
...
@@ -786,7 +786,7 @@ elif re.match('^TesteNB$', mode, re.IGNORECASE) or re.match('^TestUE$', mode, re
elif
action
==
'Cppcheck_Analysis'
:
SCA
.
CppCheckAnalysis
(
HTML
)
elif
action
==
'Deploy_Run_PhySim'
:
PHYSIM
.
Deploy_PhySim
(
HTML
)
PHYSIM
.
Deploy_PhySim
(
HTML
,
RAN
)
else
:
sys
.
exit
(
'Invalid class (action) from xml'
)
if
not
RAN
.
prematureExit
:
...
...
ci-scripts/ran.py
View file @
bf5e726f
...
...
@@ -148,7 +148,7 @@ class RANManagement():
# on RedHat/CentOS .git extension is mandatory
result
=
re
.
search
(
'([a-zA-Z0-9\:\-\.\/])+\.git'
,
self
.
ranRepository
)
if
result
is
not
None
:
full_ran_repo_name
=
self
.
ranRepository
full_ran_repo_name
=
self
.
ranRepository
.
replace
(
'git/'
,
'git'
)
else
:
full_ran_repo_name
=
self
.
ranRepository
+
'.git'
mySSH
.
command
(
'mkdir -p '
+
lSourcePath
,
'\$'
,
5
)
...
...
@@ -191,7 +191,7 @@ class RANManagement():
mySSH
.
command
(
'echo '
+
lPassWord
+
' | sudo -S git clean -x -d -ff'
,
'\$'
,
30
)
# if the commit ID is provided use it to point to it
if
self
.
ranCommitID
!=
''
:
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
5
)
mySSH
.
command
(
'git checkout -f '
+
self
.
ranCommitID
,
'\$'
,
30
)
# if the branch is not develop, then it is a merge request and we need to do
# the potential merge. Note that merge conflicts should already been checked earlier
if
(
self
.
ranAllowMerge
):
...
...
ci-scripts/xml_files/container_image_build.xml
View file @
bf5e726f
...
...
@@ -35,6 +35,7 @@
<kind>
all
</kind>
<eNB_instance>
0
</eNB_instance>
<eNB_serverId>
0
</eNB_serverId>
<forced_workspace_cleanup>
True
</forced_workspace_cleanup>
</testCase>
</testCaseList>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment