We are now sending either SR or HARQ based on UL_TTI_REQ

This requires some updates to the nFAPI code as well.
We also have declared the def_dci_rel15 extern variable
consistently throughout the code.

In this commit, the gNB is still crashing. However, it seems
that the NSA UE is sending the proper responses back, but there
some sort of incorrect management of the def_dci_pdu_rel15
variable. If we memset this array to 0, we can see incorrect
0 assignments to elements of the UCI indications. Hopefully
fixing this issue will result in less gNB crashes.

nfapi/oai_integration/nfapi_vnf.c

@@ -788,17 +788,21 @@ int phy_nr_uci_indication(nfapi_nr_uci_indication_t *ind)
         case NFAPI_NR_UCI_FORMAT_0_1_PDU_TYPE: {
           nfapi_nr_uci_pucch_pdu_format_0_1_t *uci_ind_pdu = &uci_ind->uci_list[i].pucch_pdu_format_0_1;
           nfapi_nr_uci_pucch_pdu_format_0_1_t *ind_pdu = &ind->uci_list[i].pucch_pdu_format_0_1;
-          
+          if (ind_pdu->sr) {
+            uci_ind_pdu->sr = CALLOC(1, sizeof(*uci_ind_pdu->sr));
+            AssertFatal(uci_ind_pdu->sr != NULL, "Memory not allocated for uci_ind_pdu->harq in phy_nr_uci_indication.");
+            *uci_ind_pdu->sr = *ind_pdu->sr;
+          }
+          if (ind_pdu->harq) {
             uci_ind_pdu->harq = CALLOC(1, sizeof(*uci_ind_pdu->harq));
             AssertFatal(uci_ind_pdu->harq != NULL, "Memory not allocated for uci_ind_pdu->harq in phy_nr_uci_indication.");
 
             *uci_ind_pdu->harq = *ind_pdu->harq;
-
             uci_ind_pdu->harq->harq_list = CALLOC(uci_ind_pdu->harq->num_harq, sizeof(*uci_ind_pdu->harq->harq_list));
             AssertFatal(uci_ind_pdu->harq->harq_list != NULL, "Memory not allocated for uci_ind_pdu->harq->harq_list in phy_nr_uci_indication.");
             for (int j = 0; j < uci_ind_pdu->harq->num_harq; j++)
                 uci_ind_pdu->harq->harq_list[j].harq_value =  ind_pdu->harq->harq_list[j].harq_value;
-          
+          }
           break;
         }
 
@@ -832,8 +836,16 @@ int phy_nr_uci_indication(nfapi_nr_uci_indication_t *ind)
       {
           if (uci_ind->uci_list[i].pdu_type == NFAPI_NR_UCI_FORMAT_0_1_PDU_TYPE)
           {
+            if (uci_ind->uci_list[i].pucch_pdu_format_0_1.harq) {
               free(uci_ind->uci_list[i].pucch_pdu_format_0_1.harq->harq_list);
+              uci_ind->uci_list[i].pucch_pdu_format_0_1.harq->harq_list = NULL;
               free(uci_ind->uci_list[i].pucch_pdu_format_0_1.harq);
+              uci_ind->uci_list[i].pucch_pdu_format_0_1.harq = NULL;
+            }
+            if (uci_ind->uci_list[i].pucch_pdu_format_0_1.sr) {
+              free(uci_ind->uci_list[i].pucch_pdu_format_0_1.sr);
+              uci_ind->uci_list[i].pucch_pdu_format_0_1.sr = NULL;
+            }
           }
           if (uci_ind->uci_list[i].pdu_type == NFAPI_NR_UCI_FORMAT_2_3_4_PDU_TYPE)
           {
@@ -843,7 +855,9 @@ int phy_nr_uci_indication(nfapi_nr_uci_indication_t *ind)
           }
       }
       free(uci_ind->uci_list);
+      uci_ind->uci_list = NULL;
       free(uci_ind);
+      uci_ind = NULL;
     }
   }
   else {

nfapi/open-nFAPI/nfapi/src/nfapi_p7.c

@@ -5865,7 +5865,12 @@ static uint8_t unpack_nr_uci_pucch_0_1(nfapi_nr_uci_pucch_pdu_format_0_1_t *valu
 		 ))
 		  return 0;
 	if (value->pduBitmap & 0x01) { //SR
-		value->sr = (nfapi_nr_sr_pdu_0_1_t*) malloc(sizeof(nfapi_nr_sr_pdu_0_1_t));
+		value->sr = nfapi_p7_allocate(sizeof(*value->sr), config);
+		if (value->sr == NULL)
+		{
+			NFAPI_TRACE(NFAPI_TRACE_ERROR, "%s failed to allocate sr pdu\n", __FUNCTION__);
+			return 0;
+		}
 		if(!(pull8(ppReadPackedMsg, &value->sr->sr_indication, end) &&
 	 	 pull8(ppReadPackedMsg, &value->sr->sr_confidence_level, end) 
 		 ))

openair1/SCHED_NR_UE/fapi_nr_ue_l1.c

@@ -92,7 +92,7 @@ int8_t nr_ue_scheduled_response_stub(nr_scheduled_response_t *scheduled_response
                 memcpy(rx_ind->pdu_list[j].pdu, tx_req_body->pdu, tx_req_body->pdu_length * sizeof(*rx_ind->pdu_list[j].pdu));
                 rx_ind->pdu_list[j].rnti = pusch_config_pdu->rnti;
                 rx_ind->pdu_list[j].timing_advance = scheduled_response->tx_request->tx_config.timing_advance;
-                rx_ind->pdu_list[j].ul_cqi = scheduled_response->tx_request->tx_config.ul_cqi;
+                rx_ind->pdu_list[j].ul_cqi = 255; // scheduled_response->tx_request->tx_config.ul_cqi;
                 char buffer[1024];
                 hexdump(rx_ind->pdu_list[j].pdu, rx_ind->pdu_list[j].pdu_length, buffer, sizeof(buffer));
                 LOG_D(MAC, "Melissa Elkadi, this is hexdump of pdu %s before queuing rx_ind\n",
@@ -183,38 +183,21 @@ int8_t nr_ue_scheduled_response_stub(nr_scheduled_response_t *scheduled_response
               uci_ind->uci_list[j].pdu_type = NFAPI_NR_UCI_FORMAT_0_1_PDU_TYPE;
               uci_ind->uci_list[j].pdu_size = sizeof(nfapi_nr_uci_pucch_pdu_format_0_1_t);
               memset(pdu_0_1, 0, sizeof(*pdu_0_1));
-              pdu_0_1->pduBitmap = 2; // (value->pduBitmap >> 1) & 0x01) == HARQ and (value->pduBitmap) & 0x01) == SR
               pdu_0_1->handle = 0;
               pdu_0_1->rnti = dl_config->dl_config_list[i].dlsch_config_pdu.rnti;
               pdu_0_1->pucch_format = 1;
-              pdu_0_1->ul_cqi = 27;
+              pdu_0_1->ul_cqi = 255;
               pdu_0_1->timing_advance = 0;
               pdu_0_1->rssi = 0;
-              pdu_0_1->harq = CALLOC(1, sizeof(*pdu_0_1->harq));
-              pdu_0_1->harq->num_harq = 1;
-              pdu_0_1->harq->harq_confidence_level = 0;
-              pdu_0_1->harq->harq_list = CALLOC(pdu_0_1->harq->num_harq, sizeof(*pdu_0_1->harq->harq_list));
-              for (int k = 0; k < pdu_0_1->harq->num_harq; k++)
-              {
-                pdu_0_1->harq->harq_list[k].harq_value = 0;
-              }
             }
 
             LOG_I(NR_PHY, "In %s: Filled queue uci_ind which was filled by dlconfig.\n"
-                       "uci_num %d, uci_slot %d, uci_frame %d and num_harqs %d\n",
-                          __FUNCTION__, uci_ind->num_ucis, uci_ind->slot, uci_ind->sfn, uci_ind->uci_list[0].pucch_pdu_format_0_1.harq->num_harq);
+                       "uci_num %d, SFN/SLOT: [%d, %d]\n",
+                          __FUNCTION__, uci_ind->num_ucis, uci_ind->sfn, uci_ind->slot);
 
             if (!put_queue(&nr_uci_ind_queue, uci_ind))
             {
               LOG_E(NR_MAC, "Put_queue failed for uci_ind\n");
-              //free(uci_ind->uci_list[0].pucch_pdu_format_0_1.harq->harq_list);
-              //free(uci_ind->uci_list[0].pucch_pdu_format_0_1.harq);
-              for (int j = 0; j < uci_ind->num_ucis; j++)
-              {
-                nfapi_nr_uci_pucch_pdu_format_0_1_t *pdu_0_1 = &uci_ind->uci_list[j].pucch_pdu_format_0_1;
-                free(pdu_0_1->harq->harq_list);
-                free(pdu_0_1->harq);
-              }
               free(uci_ind->uci_list);
               free(uci_ind);
             }

openair2/LAYER2/NR_MAC_COMMON/nr_mac_extern.h

@@ -39,7 +39,7 @@
 
 extern const uint8_t nr_slots_per_frame[5];
 
-extern dci_pdu_rel15_t *def_dci_pdu_rel15;
+extern dci_pdu_rel15_t def_dci_pdu_rel15[8];
 
 /* extern const uint32_t BSR_TABLE[BSR_TABLE_SIZE];
 extern const uint32_t Extended_BSR_TABLE[BSR_TABLE_SIZE];

openair2/LAYER2/NR_MAC_UE/mac_extern.h

@@ -66,7 +66,7 @@ extern const uint8_t table_7_3_2_3_3_4_twoCodeword[6][10];
 
 extern const uint16_t table_7_2_1[16];
 
-extern dci_pdu_rel15_t *def_dci_pdu_rel15;
+extern dci_pdu_rel15_t def_dci_pdu_rel15[8];
 
 extern void mac_rlc_data_ind(const module_id_t         module_idP,
                              const rnti_t              rntiP,

openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_uci.c

@@ -1109,8 +1109,10 @@ void handle_nr_uci_pucch_0_1(module_id_t mod_id,
   // tpc (power control) only if we received AckNack or positive SR. For a
   // negative SR, the UE won't have sent anything, and the SNR is not valid
   if (((uci_01->pduBitmap >> 1) & 0x1) || sched_ctrl->SR) {
-    if (uci_01->harq->harq_confidence_level==0) sched_ctrl->tpc1 = nr_get_tpc(RC.nrmac[mod_id]->pucch_target_snrx10, uci_01->ul_cqi, 30);
-    else                                        sched_ctrl->tpc1 = 3;
+    if (((uci_01->pduBitmap >> 1) & 0x1) && uci_01->harq->harq_confidence_level==0)
+      sched_ctrl->tpc1 = nr_get_tpc(RC.nrmac[mod_id]->pucch_target_snrx10, uci_01->ul_cqi, 30);
+    else
+      sched_ctrl->tpc1 = 3;
     sched_ctrl->pucch_snrx10 = uci_01->ul_cqi * 5 - 640;
   }
 }

openair2/NR_PHY_INTERFACE/NR_IF_Module.c

@@ -156,8 +156,16 @@ void handle_nr_uci(NR_UL_IND_t *UL_info)
   for (int i = 0; i < num_ucis; i++) {
     switch (uci_list[i].pdu_type) {
       case NFAPI_NR_UCI_FORMAT_0_1_PDU_TYPE:
+        if (uci_list[i].pucch_pdu_format_0_1.harq) {
         free(uci_list[i].pucch_pdu_format_0_1.harq->harq_list);
+        uci_list[i].pucch_pdu_format_0_1.harq->harq_list = NULL;
         free(uci_list[i].pucch_pdu_format_0_1.harq);
+        uci_list[i].pucch_pdu_format_0_1.harq = NULL;
+        }
+        if (uci_list[i].pucch_pdu_format_0_1.sr) {
+          free(uci_list[i].pucch_pdu_format_0_1.sr);
+          uci_list[i].pucch_pdu_format_0_1.sr = NULL;
+        }
         break;
 
       case NFAPI_NR_UCI_FORMAT_2_3_4_PDU_TYPE:
@@ -167,9 +175,12 @@ void handle_nr_uci(NR_UL_IND_t *UL_info)
         break;
     }
   }
-  if (uci_ind && num_ucis > 0)
+  if (uci_ind && num_ucis > 0) {
     free(uci_list);
+    uci_list = NULL;
+  }
   free(uci_ind);
+  uci_ind = NULL;
 }
 
 static bool crc_sfn_slot_matcher(void *wanted, void *candidate)

openair2/NR_UE_PHY_INTERFACE/NR_IF_Module.c

@@ -392,29 +392,42 @@ static void copy_ul_tti_data_req_to_dl_info(nr_downlink_indication_t *dl_info, n
     for (int i = 0; i < num_pdus; i++)
     {
         nfapi_nr_ul_tti_request_number_of_pdus_t *pdu_list = &ul_tti_req->pdus_list[i];
-        LOG_D(NR_PHY, "This is the pdu type %d and rnti %x in ul_tti_req\n",
-              pdu_list->pdu_type, ul_tti_req->pdus_list[i].pucch_pdu.rnti);
+        LOG_D(NR_PHY, "This is the pdu type %d and rnti %x and SR flag %d and harq_pdu_len %d in in ul_tti_req\n",
+              pdu_list->pdu_type, ul_tti_req->pdus_list[i].pucch_pdu.rnti, pdu_list->pucch_pdu.sr_flag, pdu_list->pucch_pdu.bit_len_harq);
         if (pdu_list->pdu_type == NFAPI_NR_UL_CONFIG_PUCCH_PDU_TYPE && pdu_list->pucch_pdu.rnti == mac->crnti)
         {
             LOG_I(NR_MAC, "This is the number of UCIs in the queue %ld\n", nr_uci_ind_queue.num_items);
             nfapi_nr_uci_indication_t *uci_ind = get_queue(&nr_uci_ind_queue);
-            if (uci_ind)
-            {
-                LOG_I(NR_MAC, "This is the SFN/SF [%d, %d] of the UCI ind. \n", uci_ind->sfn, uci_ind->slot);
-                if (uci_ind->num_ucis > 0)
+            if (uci_ind && uci_ind->num_ucis > 0)
             {
+                LOG_D(NR_MAC, "This is the SFN/SF [%d, %d] and RNTI %x of the UCI ind. ul_tti_req.pdu[%d]->rnti = %x \n",
+                        uci_ind->sfn, uci_ind->slot, uci_ind->uci_list[0].pucch_pdu_format_0_1.rnti, i, ul_tti_req->pdus_list[i].pucch_pdu.rnti);
                 uci_ind->sfn = ul_tti_req->SFN;
                 uci_ind->slot = ul_tti_req->Slot;
-                    if (pdu_list->pucch_pdu.sr_flag)
-                    {
                 for (int j = 0; j < uci_ind->num_ucis; j++)
                 {
                     nfapi_nr_uci_pucch_pdu_format_0_1_t *pdu_0_1 = &uci_ind->uci_list[j].pucch_pdu_format_0_1;
+                    if (pdu_list->pucch_pdu.sr_flag)
+                    {
+                        LOG_D(NR_MAC, "We have the SR flag in pdu i %d\n", i);
+                        pdu_0_1->pduBitmap = 1; // (value->pduBitmap >> 1) & 0x01) == HARQ and (value->pduBitmap) & 0x01) == SR
                         pdu_0_1->sr = CALLOC(1, sizeof(*pdu_0_1->sr));
                         pdu_0_1->sr->sr_confidence_level = 0;
-                          pdu_0_1->sr->sr_indication = 0;
+                        pdu_0_1->sr->sr_indication = 1;
+                    }
+                    if (pdu_list->pucch_pdu.bit_len_harq > 0)
+                    {
+                        LOG_D(NR_MAC, "We have the Harq len bits %d\n", pdu_list->pucch_pdu.bit_len_harq);
+                        pdu_0_1->pduBitmap = 2; // (value->pduBitmap >> 1) & 0x01) == HARQ and (value->pduBitmap) & 0x01) == SR
+                        pdu_0_1->harq = CALLOC(1, sizeof(*pdu_0_1->harq));
+                        pdu_0_1->harq->num_harq = 1;
+                        pdu_0_1->harq->harq_confidence_level = 0;
+                        pdu_0_1->harq->harq_list = CALLOC(pdu_0_1->harq->num_harq, sizeof(*pdu_0_1->harq->harq_list));
+                        for (int k = 0; k < pdu_0_1->harq->num_harq; k++)
+                        {
+                            pdu_0_1->harq->harq_list[k].harq_value = 0;
+                        }
                     }
-
                 }
                 LOG_I(NR_MAC, "We have dequeued the previously filled uci_ind and updated the snf/slot to %d/%d.\n",
                       uci_ind->sfn, uci_ind->slot);
@@ -422,16 +435,27 @@ static void copy_ul_tti_data_req_to_dl_info(nr_downlink_indication_t *dl_info, n
                     .uci_ind = *uci_ind,
                 };
                 send_nsa_standalone_msg(&UL_INFO, uci_ind->header.message_id);
-                }
+
                 for (int k = 0; k < uci_ind->num_ucis; k++)
                 {
                     nfapi_nr_uci_pucch_pdu_format_0_1_t *pdu_0_1 = &uci_ind->uci_list[k].pucch_pdu_format_0_1;
+                    if (pdu_list->pucch_pdu.sr_flag)
+                    {
                         free(pdu_0_1->sr);
+                        pdu_0_1->sr = NULL;
+                    }
+                    if (pdu_list->pucch_pdu.bit_len_harq > 1)
+                    {
                         free(pdu_0_1->harq->harq_list);
+                        pdu_0_1->harq->harq_list = NULL;
                         free(pdu_0_1->harq);
+                        pdu_0_1->harq = NULL;
+                    }
                 }
                 free(uci_ind->uci_list);
+                uci_ind->uci_list = NULL;
                 free(uci_ind);
+                uci_ind = NULL;
             }
 
         }
@@ -898,7 +922,7 @@ int nr_ue_dl_indication(nr_downlink_indication_t *dl_info, NR_UL_TIME_ALIGNMENT_
   NR_UE_MAC_INST_t *mac = get_mac_inst(module_id);
   fapi_nr_dl_config_request_t *dl_config = &mac->dl_config_request;
 
-  if ((!dl_info->dci_ind && !dl_info->rx_ind)) { //Melissa review this with Raymond|| !def_dci_pdu_rel15
+  if ((!dl_info->dci_ind && !dl_info->rx_ind)) {
     // UL indication to schedule DCI reception
     nr_ue_scheduler(dl_info, NULL);
   } else {