- 12 May, 2017 7 commits
-
-
gabrielC authored
```------------------------------------------------------- bug 37 Ttile: Sending side is as follows. rar[3] = (((mcs&0x7)<<5)) | ((TPC&7)<<2) | ((ULdelay&1)<<1) | (cqireq&1); So, 2 bit shift looks correct. Bug Location: ulsch->harq_processes[harq_pid]->TPC = (rar[3]>>3)&7;//rar->TPC; ``` -------------------------------------------------------
-
gabrielC authored
```------------------------------------------------------- bug 29 Ttile: FDD should be TDD. Bug Location: switch (oai_emulation.info.frame_type[0]) { case FDD: frame_type = "FDD"; break; case TDD: frame_type = "FDD"; break; } ``` -------------------------------------------------------
-
gabrielC authored
```------------------------------------------------------- bug 26 Ttile: g_buffer has only 32 index, but he/she tries to zero clear 1024 index. Bug Location: static uint8_t g_buffer[32]; : memset (g_buffer, 0, 1024); Note: Detected by CppCheck ``` -------------------------------------------------------
-
Cedric Roux authored
```------------------------------------------------------- bug 24 Ttile: The last line "multicast_group = multicast_group" is hard to understand. The local variable should be different name than the global variable. Bug Location: const char *multicast_group_list[MULTICAST_LINK_NUM_GROUPS] = { "239.0.0.161", "239.0.0.162", "239.0.0.163", "239.0.0.164" }; : : void multicast_link_start(void (*rx_handlerP) (unsigned int, char *), unsigned char multicast_group, char *multicast_ifname) { rx_handler = rx_handlerP; multicast_group = multicast_group; Note: Detected by CppCheck ``` -------------------------------------------------------
-
gabrielC authored
Note: not sure that the code is correct, to be checked (Cédric Roux). ---------------------------------------------------------- bug 22 Ttile: (subframe!=2)||(subframe!=7) is always TRUE. This coding is really intended? Operator || should be && instead? Bug Location: ((frame_parms->frame_type==TDD)&&(frame_parms->tdd_config==1)&&((subframe!=2)||(subframe!=7)))) { Note: Detected by CppCheck ----------------------------------------------------------
-
gabrielC authored
Note: this fix does not solve the issue with how this buffer is used in this function, but I'm not sure this code is used at all (Cédric Roux). ---------------------------------------------------------- bug 21 Ttile: PAYLOAD_MAX=1500, so this coding results in index overflow. Additionally, operator "!=" just compairs something, this coding is meaningless. Bug Location: buffer[PAYLOAD_MAX] != '\0'; Note: Detected by CppCheck ----------------------------------------------------------
-
gabrielC authored
```------------------------------------------------------- bug 18 Ttile: Probably he/she wants to copy the contents of arrays, but this coding doesn't copy anything, moreover index overflow occurs. Bug Location: u2e_t[UE_id][eNB_id]->tx_data[3]=tx[eNB_id][3]; u2e_t[UE_id][eNB_id]->rx_data[3]=rx[NB_eNB_INST+UE_id][3]; Note: Detected by CppCheck ``` ------------------------------------------------------- bug 19 Title: Probably he/she wants to copy the contents of arrays, but this coding doesn't copy anything, moreover index overflow occurs. Bug Location: e2u_t[eNB_id][UE_id]->tx_data[3]=tx[NB_eNB_INST+UE_id][3]; e2u_t[eNB_id][UE_id]->rx_data[3]=rx[eNB_id][3]; Note: Detected by CppCheck ---------------------------------------------------------- bug 20 Title: Probably he/she wants to copy the contents of arrays, but this coding doesn't copy anything, moreover index overflow occurs. Bug Location: tx_data[3]=cthread->tx_data[3]; rx_data[3]=cthread->rx_data[3]; Note: Detected by CppCheck ----------------------------------------------------------
-
- 18 Apr, 2017 2 commits
-
-
Cedric Roux authored
develop_integration_w15 into develop Summary of changes: - DCI1 20MHz phy-test bug fix - RLC UM/AM max header size fix - UE autotests improvements See merge request !177
-
Cedric Roux authored
- RBs set to 25 - disable SRS
-
- 14 Apr, 2017 6 commits
-
-
Cedric Roux authored
In 20MHz the UE didn't do any uplink granted by DCI0. It was replying to RAR, so uplink decoding was okay. Turns out the DCI0 structure for TDD was wrong.
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
Merge remote-tracking branch 'origin/bugfix-234-rlc-um-max-header-size' into develop_integration_w15
-
tctalcatel authored
-
tctalcatel authored
-
- 12 Apr, 2017 1 commit
-
-
tctalcatel authored
-
- 11 Apr, 2017 2 commits
-
-
GabrielCouturier authored
-
Cedric Roux authored
Fabrice Nabet (TCL) suggests the value 128 for both. See https://gitlab.eurecom.fr/oai/openairinterface5g/issues/234#note_3179
-
- 10 Apr, 2017 5 commits
-
-
Cedric Roux authored
The constant RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU is set to 24. This is too low. Running a downlink TCP iperf with a 10MHz or 20MHz cell leads to lots of the following warning in the log: [RLC][W][SN 792] Bad RLC header! Discard this RLC PDU (size=618) The problem is that the uplink RLC PDU contains a lot of TCP ack. We can see much more than 24 of them. The RLC layer is not happy and discards the PDU. Putting 256 for RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU (arbitrarily chosen, big but not too big) solves the problem, at least for 10MHz.
-
Cedric Roux authored
it was: *num_li_pP >= RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU it should be: *num_li_pP > RLC_UM_SEGMENT_NB_MAX_LI_PER_PDU
-
Cedric Roux authored
develop_integration_w14 into develop Summary of changes: - minor bug fixes, minor improvements See merge request !173
-
Cedric Roux authored
Using "system" to call "git log" is too error-prone. In the test setup, lte-softmodem was blocked because "git log" uses a pager ("less") and the pager was waiting for the user to press enter. We could pass "--no-pager" to "git log" but then what if someone runs the softmodem out of the source tree? cmake defines PACKAGE_VERSION, we can use that instead, as is done in openair-cn.
-
Cedric Roux authored
-
- 08 Apr, 2017 1 commit
-
-
Florian Kaltenberger authored
-
- 07 Apr, 2017 2 commits
-
-
Cedric Roux authored
-
Cedric Roux authored
-
- 03 Apr, 2017 4 commits
-
-
Cedric Roux authored
This reverts commit 7f24927c. With value 13 uplink TDD for a 10MHz configuration was not working. UDP traffic sent with: "iperf -c XX -u -b10M" was crashing the eNB.
-
gabrielC authored
-
Cedric Roux authored
Develop integration w13 Summary of changes: - RLC AM reworking (a lot has changed) - several bug fixes * support processing multiple MAC RAR control elements in a single MSG2 * fix ACK/NACK resetting * do not correct USRP frequency from carrier offset estimation when --ue-carrier-scan == off * fix TDD uplink due to incorrect PUCCH format for SR in TDD * several other simple fixes - better support for LMS SDR See merge request !168
-
Cedric Roux authored
- define _GNU_SOURCE before including pthread.h - do not use static for the array 'threadname' used to store the name, it makes it a global variable accessed by several threads in parallel - increase size of 'threadname' (maybe not necessary) - properly indent #define / #under (# should be at column 1)
-
- 30 Mar, 2017 1 commit
-
-
Cedric Roux authored
-
- 29 Mar, 2017 1 commit
-
-
hbilel authored
-
- 28 Mar, 2017 8 commits
-
-
hbilel authored
-
hbilel authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
When you ran it with the scope as: ./dlsim -X you saw no activity in the "PDSCH I/Q of MF Output" window, so matter what SNR you put (even for very high SNR, say: ./dlsim -X -s40) this commit seems to fix it. I am not sure it is the end of story. The 2 threads PDCCH/PDSCH structures may still not be used correctly everywhere.
-
Florian Kaltenberger authored
-
Cedric Roux authored
-
Cedric Roux authored
-