Conflicts:
	openair2/ENB_APP/flexran_agent_common_internal.c
	openair2/LAYER2/MAC/eNB_scheduler_dlsch.c

Merge remote-tracking branch 'origin/issue343_dlcqi_retransmission' into develop_integration_2018_w36

Conflicts:
	openair1/PHY/INIT/init_top.c

Note: we don't include the last commit from origin/recode_itti_from_scratch
because it is just astyle formatting. As of today we don't enforce
astyle and including this work would lead to future merge conflicts.
A proper process to enforce astyle has to be put in place. In the
meantime, no astyle allowed in commits if the changes are too big
and not relevant to work done.

The bug popped up when one UE was doing TCP UL iperf and a second UE
attempted to connect. A crash of the eNB happened because we changed
the wrong NFAPI structure in a TTI where both UEs are scheduled.

Something like that.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Fix: RAN API: remove_ul_slice() frees ul sched_name pointer, when sched_name set, free it when resetting

Commit 7823858e2d11e8cabc1ca7bf7f507b9a050942d3 introduced this as a comment.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Using valgrind revealed that those two arrays
were too small. Let's use 512 bytes, which should
be enough for every practical cases.

This includes damages check_vcd.c in the T tracer
(in develop branch).

Using the basic simulator and valgrind, it was found that
the lack of initialization of those two pointers leads to
some very nasty behavior of some other parts of the system.

This reverts commit 31821838.

The comparison in AssertFatal was not correct,
taking the opposite meaning to the one expected.

In the eNB it's not really used for the moment because there
is a limitation to uplink scheduling. In
openair2/LAYER2/MAC/eNB_scheduler_ulsch.c we have:

            while (((rb_table[rb_table_index] > (N_RB_UL - 1 - first_rb[CC_id]))
                    || (rb_table[rb_table_index] > 45))

That limits uplink scheduling to at most 44 RBs. The 768 case is for
64 RBs.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>