The previous implementation has the notion of 'task ready' that is
removed from the new implementation.

When a task is created, it initializes some data structures and whatever
and then marks itself ready. Then it waits for all the other tasks to
be also ready. Then it does what it has to do.

The task creator creates all the tasks, then waits for each of them to
be ready then it sets a global variable to signal all the tasks that
all the other tasks are ready and that they can start their work.

The new ITTI implementation wants to be API-compatible with the previous
implementation but completely fails to respect this initialization
mechanism, leading to various random crashes.

We already observe some failures in the CI testbench with the basic
simulator.

This commit is not to be integrated into the develop branch but is done
to check if the analysis above is correct.

If it is then the basic simulator should work properly in the CI, as it
more or less used to do with the previous IITI implementation.

And then we need a proper fix. What is done here is not really satisfying.
(But can go into develop if no cleaner solution is found.)

Let's see...

When compiling in debug mode, the 'inline' semantics of C99 led to the errors:

/roux/w25/openairinterface5g/common/utils/LOG/log.c:479: undefined reference to `log_header'
libUTIL.a(log.c.o): In function `log_dump':
/roux/w25/openairinterface5g/common/utils/LOG/log.c:502: undefined reference to `log_header'
collect2: error: ld returned 1 exit status

Let's use static instead of inline.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Summary of changes:
- work on flexran
- work on X2
- new implementation of ITTI
- code cleanup
- bug fixes

If the IP address for X2AP is not good, the error message reported
was very unclear. Attempt to make it better.

This commit manually reverts the commits:
- 97c69dc4
- 3278aa49

The basic simulator was not functional anymore because
the UE did not send RRCConnectionSetupComplete due to
some problem in the PDCP layer, most probably.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

This break was there and went away, for whatever reason...

Merge remote-tracking branch 'origin/347-remove-assertion-ue-dci-handling' into develop_integration_2018_w36

Conflicts:
	openair2/ENB_APP/flexran_agent_common_internal.c
	openair2/LAYER2/MAC/eNB_scheduler_dlsch.c

Merge remote-tracking branch 'origin/issue343_dlcqi_retransmission' into develop_integration_2018_w36

Conflicts:
	openair1/PHY/INIT/init_top.c

Note: we don't include the last commit from origin/recode_itti_from_scratch
because it is just astyle formatting. As of today we don't enforce
astyle and including this work would lead to future merge conflicts.
A proper process to enforce astyle has to be put in place. In the
meantime, no astyle allowed in commits if the changes are too big
and not relevant to work done.

Conflicts:
	cmake_targets/CMakeLists.txt
	openair2/ENB_APP/enb_app.c
	openair2/X2AP/x2ap_common.h

The bug popped up when one UE was doing TCP UL iperf and a second UE
attempted to connect. A crash of the eNB happened because we changed
the wrong NFAPI structure in a TTI where both UEs are scheduled.

Something like that.

SCTP: one to many sockets implementation

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Fix: RAN API: remove_ul_slice() frees ul sched_name pointer, when sched_name set, free it when resetting