• Haim Grosman's avatar
    EventBase::runAfterDelay to throw an exception · 1a61493f
    Haim Grosman authored
    Summary:
    EventBase::runAfterDelay to throw an exception in case it fails to
    schedule a proper execution of the given callback
    (instead of silently returning false)
    
    it appears to be the right thing to do, since:
    @davejwatson: Digging through the layers of code, it appears this can only fail if
    epoll_ctl() with EPOLL_CTL_ADD fails. Ignoring libevent bugs, it looks
    like the only relevant errors could be ENOMEM or ENOSPC. So
    nonrecoverable
    
    Test Plan: Unit tests
    
    Reviewed By: anca@fb.com
    
    Subscribers: yzhan, haijunz, simpkins, net-systems@, varunk, zeus-diffs@, nli, dfechete, fugalh, atlas2-eng@, alandau, bmatheny, everstore-dev@, zhuohuang, wormhole-diffs@, anca, mwa, jgehring, oujin, alikhtarov, fuegen, mshneer, wch, bil, sanketh, zippydb, maxwellsayles, jsedgwick, trunkagent, fbcode-common-diffs@, chaoyc, search-fbcode-diffs@, andrewcox, unicorn-diffs@, tw-eng@, xie, kennyyu, yfeldblum, folly-diffs@, davejwatson
    
    FB internal diff: D1805125
    
    Signature: t1:1805125:1424927912:8bebb4c3b9f1fa189c0ce97b12cdb8f95dba97ae
    1a61493f
EventBaseTest.cpp 46.8 KB