• Yedidya Feldblum's avatar
    Remove <glog/logging.h> from folly/Indestructible.h · 8f22c4e3
    Yedidya Feldblum authored
    Summary:
    [Folly] Remove `<glog/logging.h>` from `folly/Indestructible.h`.
    
    This makes the header much lighter. And abort on invalid access (the use-case for `glog`) only in `!defined(NDEBUG)` mode.
    
    Anti-Pattern Combined Mega-Diff Description:
    * Add non-`explicit` default ctor.
    * Disable ctor explicitly when underlying ctor would fail to compile. Not sure how useful it would be, but it makes type-traits work correctly for whatever that is worth.
    * Switch boolean flag to `erased_{false}` so that it is zero-initializable, because that's better.
    
    Reviewed By: ericniebler
    
    Differential Revision: D4380469
    
    fbshipit-source-id: a39cb7470f7ee678fa722778da587409f468d985
    8f22c4e3
Makefile.am 14.6 KB