AsyncSSLSocket::newSocket fd to NetworkSocket overload

Summary: So that the fd overload can be removed.

Reviewed By: yfeldblum

Differential Revision: D13628683

fbshipit-source-id: 5201d3ef351042ebaf2d30c3987b931f8d13d336

folly/io/async/AsyncSSLSocket.h

@@ -259,16 +259,6 @@ class AsyncSSLSocket : public virtual AsyncSocket {
         Destructor());
   }
 
-  static std::shared_ptr<AsyncSSLSocket> newSocket(
-      const std::shared_ptr<folly::SSLContext>& ctx,
-      EventBase* evb,
-      int fd,
-      bool server = true,
-      bool deferSecurityNegotiation = false) {
-    return newSocket(
-        ctx, evb, NetworkSocket::fromFd(fd), server, deferSecurityNegotiation);
-  }
-
   /**
    * Helper function to create a client shared_ptr<AsyncSSLSocket>.
    */

folly/io/async/test/TestSSLServer.h

@@ -70,7 +70,8 @@ class SSLServerAcceptCallbackBase : public AsyncServerSocket::AcceptCallback {
     try {
       // Create a AsyncSSLSocket object with the fd. The socket should be
       // added to the event base and in the state of accepting SSL connection.
-      socket_ = AsyncSSLSocket::newSocket(ctx_, base_, fd);
+      socket_ = AsyncSSLSocket::newSocket(
+          ctx_, base_, folly::NetworkSocket::fromFd(fd));
     } catch (const std::exception& e) {
       LOG(ERROR) << "Exception %s caught while creating a AsyncSSLSocket "
                     "object with socket "