Commit 12593739 authored by Andrii Grynenko's avatar Andrii Grynenko Committed by Facebook GitHub Bot

Patch AsyncStackTest.MixedStackWalk to work with the new <coroutine> header

Summary: Depending on inlining of std library primitives (e.g. coroutine_handle) it's possible to have more frames in the stack trace.

Reviewed By: yfeldblum

Differential Revision: D26793792

fbshipit-source-id: 44fb1344353e29ec92559ee34740157373112f8f
parent 64d8f3fd
......@@ -156,12 +156,14 @@ FOLLY_NOINLINE void normalFunction() {
// 4) makeRefBlockingWaitTask()
// 5) blockingWait()
// 6) MixedStackWalk_Test::TestBody()
// Note that some extra frames could be in-between these depending on inlining
// of std library primitives (e.g. coroutine_handle).
CHECK_EQ(6, stack1.size());
CHECK_LE(6, stack1.size());
auto stack2 = walk_stack();
CHECK_EQ(6, stack2.size());
CHECK_LE(6, stack2.size());
// All except the topmost stack-frame should be the same.
CHECK(std::equal(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment