Commit 2105cec0 authored by Yedidya Feldblum's avatar Yedidya Feldblum Committed by Facebook Github Bot

Cut fbcode_builder dep for thrift on krb5

Summary: [Thrift] Cut `fbcode_builder` dep for `thrift` on `krb5`. In the past, Thrift depended on Kerberos and the `krb5` implementation for its transport-layer security. However, Thrift has since migrated fully to Transport Layer Security for its transport-layer security and no longer has any build-time dependency on `krb5`. Clean this up.

Reviewed By: stevegury, vitaut

Differential Revision: D14814205

fbshipit-source-id: dca469d22098e34573674194facaaac6c4c6aa32
parent 699acb25
...@@ -21,15 +21,12 @@ def fbcode_builder_spec(builder): ...@@ -21,15 +21,12 @@ def fbcode_builder_spec(builder):
'no1msd/mstch:git_hash', 'no1msd/mstch:git_hash',
ShellQuoted('$(git describe --abbrev=0 --tags)') ShellQuoted('$(git describe --abbrev=0 --tags)')
) )
builder.add_option('krb5/krb5:git_hash', 'krb5-1.16.1-final')
return { return {
'depends_on': [folly, fizz, sodium, rsocket, wangle, zstd], 'depends_on': [folly, fizz, sodium, rsocket, wangle, zstd],
'steps': [ 'steps': [
# This isn't a separete spec, since only fbthrift uses mstch. # This isn't a separete spec, since only fbthrift uses mstch.
builder.github_project_workdir('no1msd/mstch', 'build'), builder.github_project_workdir('no1msd/mstch', 'build'),
builder.cmake_install('no1msd/mstch'), builder.cmake_install('no1msd/mstch'),
builder.github_project_workdir('krb5/krb5', 'src'),
builder.autoconf_install('krb5/krb5'),
builder.fb_github_cmake_install('fbthrift/thrift'), builder.fb_github_cmake_install('fbthrift/thrift'),
], ],
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment