Commit 241df17c authored by Wez Furlong's avatar Wez Furlong Committed by Facebook Github Bot

getdeps: assign test owner in continuous runs

Summary:
Feed the first-party oncall data through to the testpilot
invocation.  This will set the owner of the test in continuous runs.

The oncall is passed through via the sandcastle module, which means
that you will have to manually pass it through for local testing
(see test plan), but it should automatically get picked up when
sandcastle schedules the `test` step of the job.

Reviewed By: chadaustin

Differential Revision: D17146802

fbshipit-source-id: a4f0e65853a46ed8709594c96db859ede2530b00
parent 7b373430
...@@ -386,7 +386,11 @@ class TestCmd(ProjectCmdBase): ...@@ -386,7 +386,11 @@ class TestCmd(ProjectCmdBase):
builder = m.create_builder( builder = m.create_builder(
loader.build_opts, src_dir, build_dir, inst_dir, ctx loader.build_opts, src_dir, build_dir, inst_dir, ctx
) )
builder.run_tests(install_dirs, schedule_type=args.schedule_type) builder.run_tests(
install_dirs,
schedule_type=args.schedule_type,
owner=args.test_owner,
)
install_dirs.append(inst_dir) install_dirs.append(inst_dir)
...@@ -394,6 +398,7 @@ class TestCmd(ProjectCmdBase): ...@@ -394,6 +398,7 @@ class TestCmd(ProjectCmdBase):
parser.add_argument( parser.add_argument(
"--schedule-type", help="Indicates how the build was activated" "--schedule-type", help="Indicates how the build was activated"
) )
parser.add_argument("--test-owner", help="Owner for testpilot")
def get_arg_var_name(args): def get_arg_var_name(args):
......
...@@ -75,7 +75,7 @@ class BuilderBase(object): ...@@ -75,7 +75,7 @@ class BuilderBase(object):
self._build(install_dirs=install_dirs, reconfigure=reconfigure) self._build(install_dirs=install_dirs, reconfigure=reconfigure)
def run_tests(self, install_dirs, schedule_type): def run_tests(self, install_dirs, schedule_type, owner):
""" Execute any tests that we know how to run. If they fail, """ Execute any tests that we know how to run. If they fail,
raise an exception. """ raise an exception. """
pass pass
...@@ -408,7 +408,7 @@ if __name__ == "__main__": ...@@ -408,7 +408,7 @@ if __name__ == "__main__":
env=env, env=env,
) )
def run_tests(self, install_dirs, schedule_type): def run_tests(self, install_dirs, schedule_type, owner):
env = self._compute_env(install_dirs) env = self._compute_env(install_dirs)
ctest = path_search(env, "ctest") ctest = path_search(env, "ctest")
cmake = path_search(env, "cmake") cmake = path_search(env, "cmake")
...@@ -484,6 +484,9 @@ if __name__ == "__main__": ...@@ -484,6 +484,9 @@ if __name__ == "__main__":
"buildsystem=getdeps", "buildsystem=getdeps",
] ]
if owner:
testpilot_args += ["--contacts", owner]
if schedule_type == "continuous": if schedule_type == "continuous":
runs.append( runs.append(
[ [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment