Commit 327ee770 authored by Yedidya Feldblum's avatar Yedidya Feldblum Committed by Facebook Github Bot

Remove some custom test main()'s in folly/experimental/symbolizer/

Summary:
[Folly] Remove some custom test `main()`'s in `folly/experimental/symbolizer/`.

In one of the two cases, we need to do some extra work to give `ElfFile` knowledge of the program path.

Reviewed By: ot, Orvid, philippv, luciang

Differential Revision: D6420517

fbshipit-source-id: 11c694a8342abb6fff05c368f3cda2e6287ccb4b
parent acbd746f
......@@ -25,19 +25,10 @@ uint64_t kIntegerValue = 1234567890UL;
const char* kStringValue = "coconuts";
class ElfTest : public ::testing::Test {
public:
// Path to the test binary itself; set by main()
static std::string binaryPath;
ElfTest() : elfFile_(binaryPath.c_str()) {}
~ElfTest() override {}
protected:
ElfFile elfFile_;
ElfFile elfFile_{"/proc/self/exe"};
};
std::string ElfTest::binaryPath;
TEST_F(ElfTest, IntegerValue) {
auto sym = elfFile_.getSymbolByName("kIntegerValue");
EXPECT_NE(nullptr, sym.first) << "Failed to look up symbol kIntegerValue";
......@@ -58,10 +49,3 @@ TEST_F(ElfTest, iterateProgramHeaders) {
EXPECT_NE(nullptr, phdr);
EXPECT_GE(phdr->p_filesz, 0);
}
int main(int argc, char** argv) {
testing::InitGoogleTest(&argc, argv);
gflags::ParseCommandLineFlags(&argc, &argv, true);
ElfTest::binaryPath = argv[0];
return RUN_ALL_TESTS();
}
......@@ -88,10 +88,3 @@ TEST(StackTraceTest, Signal) {
raise(SIGUSR1);
EXPECT_TRUE(handled);
}
int main(int argc, char* argv[]) {
testing::InitGoogleTest(&argc, argv);
gflags::ParseCommandLineFlags(&argc, &argv, true);
google::InitGoogleLogging(argv[0]);
return RUN_ALL_TESTS();
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment