Commit 44c12101 authored by Hannes Roth's avatar Hannes Roth Committed by Dave Watson

(Wangle) Remove some early returns in tests

Summary:
I guess they sneaked in when testing.

Also remove an `EXPECT_NE` that depended on `std::move` actually moving.

Test Plan: All the tests.

Reviewed By: hans@fb.com

FB internal diff: D1204971
parent dacdff5d
...@@ -171,14 +171,10 @@ TEST(Promise, setValue) { ...@@ -171,14 +171,10 @@ TEST(Promise, setValue) {
pod = Promise<Foo>(); pod = Promise<Foo>();
fpod = pod.getFuture(); fpod = pod.getFuture();
return;
pod.setValue(std::move(f2)); pod.setValue(std::move(f2));
Foo f3 = fpod.value(); Foo f3 = fpod.value();
EXPECT_EQ(f.name, f3.name); EXPECT_EQ(f.name, f3.name);
EXPECT_EQ(f.value, f3.value); EXPECT_EQ(f.value, f3.value);
EXPECT_NE(f.name, f2.name);
return;
Promise<unique_ptr<int>> mov; Promise<unique_ptr<int>> mov;
auto fmov = mov.getFuture(); auto fmov = mov.getFuture();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment