Commit 4a1b5a3a authored by Joe Loser's avatar Joe Loser Committed by Facebook Github Bot

Fix shellcheck warnings for bootstrap-osx-homebrew.sh (#1058)

Summary:
- Fix a few shellcheck warnings on `bootstrap-osx-homebrew.sh`.
- This will help when new changes are made to this script as
  shellcheck is run internally.
Pull Request resolved: https://github.com/facebook/folly/pull/1058

Differential Revision: D14493361

Pulled By: yfeldblum

fbshipit-source-id: e46f9d0e329fd1ebe16820bdb5614c53363c5dfe
parent db3f999e
...@@ -10,7 +10,7 @@ cd "$BASE_DIR" ...@@ -10,7 +10,7 @@ cd "$BASE_DIR"
# brew install alias # brew install alias
brew_install() { brew_install() {
brew install $@ || brew upgrade $@ brew install "$@" || brew upgrade "$@"
} }
# install deps # install deps
...@@ -19,8 +19,8 @@ install_deps() { ...@@ -19,8 +19,8 @@ install_deps() {
dependencies=(autoconf automake libtool pkg-config double-conversion glog gflags boost libevent xz snappy lz4 jemalloc openssl) dependencies=(autoconf automake libtool pkg-config double-conversion glog gflags boost libevent xz snappy lz4 jemalloc openssl)
# fetch deps # fetch deps
for dependency in ${dependencies[@]}; do for dependency in "${dependencies[@]}"; do
brew_install ${dependency} brew_install "${dependency}"
done done
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment