Commit 50757e76 authored by Marshall Cline's avatar Marshall Cline Committed by Facebook Github Bot

fix contracts for Future::hasValue() & hasException()

Summary:
* Contract for Future::hasValue() had a typo - fixed that.
* Contract for Future::hasException() was inconsistent with hasValue() - made it consistent.

Differential Revision: D9527398

fbshipit-source-id: 93e1ebd768fa38476949818c0902e06a7dab5209
parent 64a6b48f
...@@ -213,7 +213,7 @@ class FutureBase { ...@@ -213,7 +213,7 @@ class FutureBase {
/// - `valid() == true` (else throws FutureInvalid) /// - `valid() == true` (else throws FutureInvalid)
bool isReady() const; bool isReady() const;
/// True if the result is an exception (not a value) on a future for which /// True if the result is a value (not an exception) on a future for which
/// isReady returns true. /// isReady returns true.
/// ///
/// Equivalent to result().hasValue() /// Equivalent to result().hasValue()
...@@ -224,8 +224,8 @@ class FutureBase { ...@@ -224,8 +224,8 @@ class FutureBase {
/// - `isReady() == true` (else throws FutureNotReady) /// - `isReady() == true` (else throws FutureNotReady)
bool hasValue() const; bool hasValue() const;
/// True if the result is ready (`isReady() == true`) and the result is an /// True if the result is an exception (not a value) on a future for which
/// exception (not a value). /// isReady returns true.
/// ///
/// Equivalent to result().hasException() /// Equivalent to result().hasException()
/// ///
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment