Commit 61cdb3dc authored by Yedidya Feldblum's avatar Yedidya Feldblum Committed by Facebook Github Bot

Fix Build: folly/synchronization/test/ParkingLotBenchmark.cpp (sign-compare, unused-variable)

Summary: [Folly] Fix Build: `folly/synchronization/test/ParkingLotBenchmark.cpp` (`sign-compare`, `unused-variable`).

Reviewed By: djwatson

Differential Revision: D6733586

fbshipit-source-id: 04b82110e8e0b655e6b3994dbca3bd0b4bd57eef
parent 19db503e
...@@ -61,7 +61,7 @@ BENCHMARK(FutexNoWaitersWake, iters) { ...@@ -61,7 +61,7 @@ BENCHMARK(FutexNoWaitersWake, iters) {
for (auto& t : threads) { for (auto& t : threads) {
t = std::thread([&]() { t = std::thread([&]() {
b.wait(); b.wait();
for (int i = 0; i < iters; i++) { for (auto i = 0u; i < iters; i++) {
fu.futexWake(1); fu.futexWake(1);
} }
}); });
...@@ -76,14 +76,13 @@ BENCHMARK(FutexNoWaitersWake, iters) { ...@@ -76,14 +76,13 @@ BENCHMARK(FutexNoWaitersWake, iters) {
BENCHMARK_RELATIVE(ParkingLotNoWaitersWake, iters) { BENCHMARK_RELATIVE(ParkingLotNoWaitersWake, iters) {
BenchmarkSuspender susp; BenchmarkSuspender susp;
folly::detail::Futex<> fu;
SimpleBarrier b(FLAGS_threads + 1); SimpleBarrier b(FLAGS_threads + 1);
std::vector<std::thread> threads{FLAGS_threads}; std::vector<std::thread> threads{FLAGS_threads};
for (auto& t : threads) { for (auto& t : threads) {
t = std::thread([&]() { t = std::thread([&]() {
b.wait(); b.wait();
for (int i = 0; i < iters; i++) { for (auto i = 0u; i < iters; i++) {
lot.unpark(&lot, [](Unit) { return UnparkControl::RetainContinue; }); lot.unpark(&lot, [](Unit) { return UnparkControl::RetainContinue; });
} }
}); });
...@@ -115,7 +114,7 @@ BENCHMARK(FutexWakeOne, iters) { ...@@ -115,7 +114,7 @@ BENCHMARK(FutexWakeOne, iters) {
} }
susp.dismiss(); susp.dismiss();
b.wait(); b.wait();
for (int i = 0; i < iters; i++) { for (auto i = 0u; i < iters; i++) {
fu.futexWake(1); fu.futexWake(1);
} }
fu.store(1); fu.store(1);
...@@ -150,7 +149,7 @@ BENCHMARK_RELATIVE(ParkingLotWakeOne, iters) { ...@@ -150,7 +149,7 @@ BENCHMARK_RELATIVE(ParkingLotWakeOne, iters) {
} }
susp.dismiss(); susp.dismiss();
b.wait(); b.wait();
for (int i = 0; i < iters; i++) { for (auto i = 0u; i < iters; i++) {
lot.unpark(&done, [](Unit) { return UnparkControl::RemoveBreak; }); lot.unpark(&done, [](Unit) { return UnparkControl::RemoveBreak; });
} }
done = true; done = true;
...@@ -181,7 +180,7 @@ BENCHMARK(FutexWakeAll, iters) { ...@@ -181,7 +180,7 @@ BENCHMARK(FutexWakeAll, iters) {
} }
susp.dismiss(); susp.dismiss();
b.wait(); b.wait();
for (int i = 0; i < iters; i++) { for (auto i = 0u; i < iters; i++) {
fu.futexWake(threads.size()); fu.futexWake(threads.size());
} }
fu.store(1); fu.store(1);
...@@ -217,7 +216,7 @@ BENCHMARK_RELATIVE(ParkingLotWakeAll, iters) { ...@@ -217,7 +216,7 @@ BENCHMARK_RELATIVE(ParkingLotWakeAll, iters) {
} }
susp.dismiss(); susp.dismiss();
b.wait(); b.wait();
for (int i = 0; i < iters; i++) { for (auto i = 0u; i < iters; i++) {
lot.unpark(&done, [](Unit) { return UnparkControl::RemoveContinue; }); lot.unpark(&done, [](Unit) { return UnparkControl::RemoveContinue; });
} }
done = true; done = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment