make it really clear that wangle/rx is deprecated

Summary: More people are starting to use Rx. Yay! But they're trying to use `wangle/rx`. So make sure there's no doubt about its deprecated status.

Reviewed By: @yfeldblum

Differential Revision: D2196273

folly/Makefile.am

@@ -308,11 +308,11 @@ nobase_follyinclude_HEADERS = \
 	wangle/concurrent/NamedThreadFactory.h \
 	wangle/concurrent/ThreadFactory.h \
 	wangle/concurrent/ThreadPoolExecutor.h \
-	wangle/rx/Observable.h \
-	wangle/rx/Observer.h \
-	wangle/rx/Subject.h \
-	wangle/rx/Subscription.h \
-	wangle/rx/types.h \
+	wangle/deprecated/rx/Observable.h \
+	wangle/deprecated/rx/Observer.h \
+	wangle/deprecated/rx/Subject.h \
+	wangle/deprecated/rx/Subscription.h \
+	wangle/deprecated/rx/types.h \
 	wangle/ssl/ClientHelloExtStats.h \
 	wangle/ssl/DHParam.h \
 	wangle/ssl/PasswordInFile.h \

folly/wangle/concurrent/ThreadPoolExecutor.h

@@ -18,7 +18,7 @@
 #include <folly/Executor.h>
 #include <folly/wangle/concurrent/LifoSemMPMCQueue.h>
 #include <folly/wangle/concurrent/NamedThreadFactory.h>
-#include <folly/wangle/rx/Observable.h>
+#include <folly/wangle/deprecated/rx/Observable.h>
 #include <folly/Baton.h>
 #include <folly/Memory.h>
 #include <folly/RWSpinLock.h>

folly/wangle/rx/Observable.h → folly/wangle/deprecated/rx/Observable.h

@@ -16,9 +16,9 @@
 
 #pragma once
 
-#include <folly/wangle/rx/types.h> // must come first
-#include <folly/wangle/rx/Subject.h>
-#include <folly/wangle/rx/Subscription.h>
+#include <folly/wangle/deprecated/rx/types.h> // must come first
+#include <folly/wangle/deprecated/rx/Subject.h>
+#include <folly/wangle/deprecated/rx/Subscription.h>
 
 #include <folly/RWSpinLock.h>
 #include <folly/SmallLocks.h>

folly/wangle/rx/Observer.h → folly/wangle/deprecated/rx/Observer.h

@@ -16,7 +16,7 @@
 
 #pragma once
 
-#include <folly/wangle/rx/types.h> // must come first
+#include <folly/wangle/deprecated/rx/types.h> // must come first
 #include <functional>
 #include <memory>
 #include <stdexcept>

folly/wangle/rx/README.md → folly/wangle/deprecated/rx/README.md

@@ -13,16 +13,11 @@ It is basically the plural of Futures (a la Wangle).
 
 For more on Rx, I recommend these resources:
 
-- Netflix blog post (RxJava): http://techblog.netflix.com/2013/02/rxjava-netflix-api.html
-- Introduction to Rx eBook (C#): http://www.introtorx.com/content/v1.0.10621.0/01_WhyRx.html
-- The RxJava wiki: https://github.com/Netflix/RxJava/wiki
-- Netflix QCon presentation: http://www.infoq.com/presentations/netflix-functional-rx
-- https://rx.codeplex.com/
-
-There are open source C++ implementations, I haven't looked at them. They
-might be the best way to go rather than writing it NIH-style. I mostly did it
-as an exercise, to think through how closely we might want to integrate
-something like this with Wangle, and to get a feel for how it works in C++.
+Netflix blog post (RxJava): http://techblog.netflix.com/2013/02/rxjava-netflix-api.html
+Introduction to Rx eBook (C#): http://www.introtorx.com/content/v1.0.10621.0/01_WhyRx.html
+The RxJava wiki: https://github.com/Netflix/RxJava/wiki
+Netflix QCon presentation: http://www.infoq.com/presentations/netflix-functional-rx
+https://rx.codeplex.com/
 
 I haven't even tried to support move-only data in this version. I'm on the
 fence about the usage of shared_ptr. Subject is underdeveloped. A whole rich
@@ -34,3 +29,9 @@ probably riddled with lifetime corner case bugs that will come out like a
 swarm of angry bees as soon as someone tries an infinite sequence, or tries to
 partially observe a long sequence. I'm pretty sure subscribeOn has a bug that
 I haven't tracked down yet.
+
+DEPRECATED:
+This was an experimental exploration. There are better, more robust, and (most
+importantly) supported C++ implementations, notably
+[rxcpp](https://rxcpp.codeplex.com/). Use that instead. You really shouldn't
+use this one. It's unsupported and incomplete. Honest.

folly/wangle/rx/Subject.h → folly/wangle/deprecated/rx/Subject.h

@@ -16,9 +16,9 @@
 
 #pragma once
 
-#include <folly/wangle/rx/types.h> // must come first
-#include <folly/wangle/rx/Observable.h>
-#include <folly/wangle/rx/Observer.h>
+#include <folly/wangle/deprecated/rx/types.h> // must come first
+#include <folly/wangle/deprecated/rx/Observable.h>
+#include <folly/wangle/deprecated/rx/Observer.h>
 
 namespace folly { namespace wangle {
 

folly/wangle/rx/Subscription.h → folly/wangle/deprecated/rx/Subscription.h

@@ -16,8 +16,8 @@
 
 #pragma once
 
-#include <folly/wangle/rx/types.h> // must come first
-#include <folly/wangle/rx/Observable.h>
+#include <folly/wangle/deprecated/rx/types.h> // must come first
+#include <folly/wangle/deprecated/rx/Observable.h>
 
 namespace folly { namespace wangle {
 

folly/wangle/rx/test/RxBenchmark.cpp → folly/wangle/deprecated/rx/test/RxBenchmark.cpp

@@ -15,8 +15,8 @@
  */
 
 #include <folly/Benchmark.h>
-#include <folly/wangle/rx/Observer.h>
-#include <folly/wangle/rx/Subject.h>
+#include <folly/wangle/deprecated/rx/Observer.h>
+#include <folly/wangle/deprecated/rx/Subject.h>
 #include <gflags/gflags.h>
 
 using namespace folly::wangle;

folly/wangle/rx/test/RxTest.cpp → folly/wangle/deprecated/rx/test/RxTest.cpp

@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-#include <folly/wangle/rx/Observer.h>
-#include <folly/wangle/rx/Subject.h>
+#include <folly/wangle/deprecated/rx/Observer.h>
+#include <folly/wangle/deprecated/rx/Subject.h>
 #include <gtest/gtest.h>
 
 using namespace folly::wangle;