disable --allow-system-packages for generate-github-actions

Summary: Fix github actions builds for projects depending on zstd

Reviewed By: wez

Differential Revision: D26743251

fbshipit-source-id: a3fd8a14750227d025bff763cca8aa683b26a422

.github/workflows/getdeps_linux.yml

@@ -16,62 +16,62 @@ jobs:
     steps:
     - uses: actions/checkout@v1
     - name: Install system deps
-      run: sudo python3 build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive folly
+      run: sudo python3 build/fbcode_builder/getdeps.py install-system-deps --recursive folly
     - name: Fetch boost
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests boost
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests boost
     - name: Fetch ninja
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests ninja
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests ninja
     - name: Fetch cmake
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests cmake
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests cmake
     - name: Fetch double-conversion
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests double-conversion
     - name: Fetch fmt
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fmt
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests fmt
     - name: Fetch gflags
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests gflags
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests gflags
     - name: Fetch glog
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests glog
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests glog
     - name: Fetch googletest
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests googletest
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests googletest
     - name: Fetch libevent
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests libevent
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests libevent
     - name: Fetch lz4
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests lz4
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests lz4
     - name: Fetch snappy
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests snappy
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests snappy
     - name: Fetch zstd
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests zstd
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests zstd
     - name: Build boost
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests boost
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests boost
     - name: Build ninja
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests ninja
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests ninja
     - name: Build cmake
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests cmake
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests cmake
     - name: Build double-conversion
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests double-conversion
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests double-conversion
     - name: Build fmt
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests fmt
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests fmt
     - name: Build gflags
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests gflags
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests gflags
     - name: Build glog
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests glog
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests glog
     - name: Build googletest
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests googletest
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests googletest
     - name: Build libevent
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests libevent
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests libevent
     - name: Build lz4
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests lz4
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests lz4
     - name: Build snappy
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests snappy
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests snappy
     - name: Build zstd
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests zstd
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests zstd
     - name: Build folly
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly  --project-install-prefix folly:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py build --src-dir=. folly  --project-install-prefix folly:/usr/local
     - name: Copy artifacts
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --strip --src-dir=. folly _artifacts/linux  --project-install-prefix folly:/usr/local --final-install-prefix /usr/local
+      run: python3 build/fbcode_builder/getdeps.py fixup-dyn-deps --strip --src-dir=. folly _artifacts/linux  --project-install-prefix folly:/usr/local --final-install-prefix /usr/local
     - uses: actions/upload-artifact@master
       with:
         name: folly
         path: _artifacts
     - name: Test folly
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. folly  --project-install-prefix folly:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py test --src-dir=. folly  --project-install-prefix folly:/usr/local

.github/workflows/getdeps_mac.yml

@@ -16,66 +16,66 @@ jobs:
     steps:
     - uses: actions/checkout@v1
     - name: Install system deps
-      run: sudo python3 build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive folly
+      run: sudo python3 build/fbcode_builder/getdeps.py install-system-deps --recursive folly
     - name: Fetch boost
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests boost
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests boost
     - name: Fetch openssl
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests openssl
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests openssl
     - name: Fetch ninja
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests ninja
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests ninja
     - name: Fetch cmake
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests cmake
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests cmake
     - name: Fetch double-conversion
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests double-conversion
     - name: Fetch fmt
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fmt
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests fmt
     - name: Fetch gflags
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests gflags
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests gflags
     - name: Fetch glog
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests glog
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests glog
     - name: Fetch googletest
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests googletest
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests googletest
     - name: Fetch libevent
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests libevent
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests libevent
     - name: Fetch lz4
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests lz4
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests lz4
     - name: Fetch snappy
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests snappy
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests snappy
     - name: Fetch zstd
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests zstd
+      run: python3 build/fbcode_builder/getdeps.py fetch --no-tests zstd
     - name: Build boost
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests boost
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests boost
     - name: Build openssl
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests openssl
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests openssl
     - name: Build ninja
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests ninja
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests ninja
     - name: Build cmake
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests cmake
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests cmake
     - name: Build double-conversion
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests double-conversion
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests double-conversion
     - name: Build fmt
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests fmt
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests fmt
     - name: Build gflags
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests gflags
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests gflags
     - name: Build glog
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests glog
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests glog
     - name: Build googletest
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests googletest
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests googletest
     - name: Build libevent
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests libevent
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests libevent
     - name: Build lz4
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests lz4
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests lz4
     - name: Build snappy
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests snappy
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests snappy
     - name: Build zstd
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests zstd
+      run: python3 build/fbcode_builder/getdeps.py build --no-tests zstd
     - name: Build folly
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly  --project-install-prefix folly:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py build --src-dir=. folly  --project-install-prefix folly:/usr/local
     - name: Copy artifacts
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. folly _artifacts/mac  --project-install-prefix folly:/usr/local --final-install-prefix /usr/local
+      run: python3 build/fbcode_builder/getdeps.py fixup-dyn-deps --src-dir=. folly _artifacts/mac  --project-install-prefix folly:/usr/local --final-install-prefix /usr/local
     - uses: actions/upload-artifact@master
       with:
         name: folly
         path: _artifacts
     - name: Test folly
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. folly  --project-install-prefix folly:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py test --src-dir=. folly  --project-install-prefix folly:/usr/local

.github/workflows/getdeps_windows.yml

@@ -21,72 +21,72 @@ jobs:
     - name: Fix Git config
       run: git config --system core.longpaths true
     - name: Fetch boost
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests boost
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests boost
     - name: Fetch perl
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests perl
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests perl
     - name: Fetch openssl
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests openssl
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests openssl
     - name: Fetch ninja
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests ninja
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests ninja
     - name: Fetch cmake
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests cmake
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests cmake
     - name: Fetch double-conversion
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests double-conversion
     - name: Fetch fmt
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fmt
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests fmt
     - name: Fetch gflags
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests gflags
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests gflags
     - name: Fetch glog
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests glog
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests glog
     - name: Fetch googletest
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests googletest
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests googletest
     - name: Fetch libevent
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests libevent
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests libevent
     - name: Fetch lz4
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests lz4
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests lz4
     - name: Fetch snappy
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests snappy
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests snappy
     - name: Fetch zlib
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests zlib
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests zlib
     - name: Fetch zstd
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests zstd
+      run: python build/fbcode_builder/getdeps.py fetch --no-tests zstd
     - name: Build boost
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests boost
+      run: python build/fbcode_builder/getdeps.py build --no-tests boost
     - name: Build perl
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests perl
+      run: python build/fbcode_builder/getdeps.py build --no-tests perl
     - name: Build openssl
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests openssl
+      run: python build/fbcode_builder/getdeps.py build --no-tests openssl
     - name: Build ninja
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests ninja
+      run: python build/fbcode_builder/getdeps.py build --no-tests ninja
     - name: Build cmake
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests cmake
+      run: python build/fbcode_builder/getdeps.py build --no-tests cmake
     - name: Build double-conversion
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests double-conversion
+      run: python build/fbcode_builder/getdeps.py build --no-tests double-conversion
     - name: Build fmt
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests fmt
+      run: python build/fbcode_builder/getdeps.py build --no-tests fmt
     - name: Build gflags
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests gflags
+      run: python build/fbcode_builder/getdeps.py build --no-tests gflags
     - name: Build glog
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests glog
+      run: python build/fbcode_builder/getdeps.py build --no-tests glog
     - name: Build googletest
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests googletest
+      run: python build/fbcode_builder/getdeps.py build --no-tests googletest
     - name: Build libevent
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests libevent
+      run: python build/fbcode_builder/getdeps.py build --no-tests libevent
     - name: Build lz4
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests lz4
+      run: python build/fbcode_builder/getdeps.py build --no-tests lz4
     - name: Build snappy
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests snappy
+      run: python build/fbcode_builder/getdeps.py build --no-tests snappy
     - name: Build zlib
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests zlib
+      run: python build/fbcode_builder/getdeps.py build --no-tests zlib
     - name: Build zstd
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --no-tests zstd
+      run: python build/fbcode_builder/getdeps.py build --no-tests zstd
     - name: Build folly
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly 
+      run: python build/fbcode_builder/getdeps.py build --src-dir=. folly 
     - name: Copy artifacts
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. folly _artifacts/windows  --final-install-prefix /usr/local
+      run: python build/fbcode_builder/getdeps.py fixup-dyn-deps --src-dir=. folly _artifacts/windows  --final-install-prefix /usr/local
     - uses: actions/upload-artifact@master
       with:
         name: folly
         path: _artifacts
     - name: Test folly
-      run: python build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. folly 
+      run: python build/fbcode_builder/getdeps.py test --src-dir=. folly 

build/fbcode_builder/getdeps.py

@@ -851,8 +851,6 @@ jobs:
             )
 
             getdeps = f"{py3} build/fbcode_builder/getdeps.py"
-            if not args.disallow_system_packages:
-                getdeps += " --allow-system-packages"
 
             out.write("  build:\n")
             out.write("    runs-on: %s\n" % runs_on)
@@ -878,11 +876,6 @@ jobs:
                 # that we want it to use them!
                 out.write("    - name: Fix Git config\n")
                 out.write("      run: git config --system core.longpaths true\n")
-            elif not args.disallow_system_packages:
-                out.write("    - name: Install system deps\n")
-                out.write(
-                    f"      run: sudo {getdeps} install-system-deps --recursive {manifest.name}\n"
-                )
 
             projects = loader.manifests_in_dependency_order()