Skip to content

F
folly
Commit 82fb08de authored by Adin Rosenberg's avatar Adin Rosenberg Committed by Facebook Github Bot
Browse files
Options

Revert D8875766: [folly/stats] Switch to radix sort for DigestBuilder 

Differential Revision:
D8875766

Original commit changeset: d88a323e6c14

fbshipit-source-id: 0f250135c084780895c99e47509e9d41cec0b88f
parent 5ae9ed9e
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 16 deletions
folly/stats/detail/DigestBuilder-defs.h
View file @ 82fb08de
......@@ -18,7 +18,6 @@
#include <folly/stats/detail/DigestBuilder.h>
#include <boost/sort/spreadsort/spreadsort.hpp>
#include <algorithm>
#include <folly/concurrency/CacheLocality.h>
......@@ -65,7 +64,7 @@ DigestT DigestBuilder<DigestT>::build() {
for (const auto& vec : valuesVec) {
values.insert(values.end(), vec.begin(), vec.end());
}
boost::sort::spreadsort::spreadsort(values.begin(), values.end());
std::sort(values.begin(), values.end());
DigestT digest(digestSize_);
digests.push_back(digest.merge(values));
}
......@@ -84,8 +83,7 @@ void DigestBuilder<DigestT>::append(double value) {
}
cpuLocalBuf->buffer.push_back(value);
if (cpuLocalBuf->buffer.size() == bufferSize_) {
boost::sort::spreadsort::spreadsort(
cpuLocalBuf->buffer.begin(), cpuLocalBuf->buffer.end());
std::sort(cpuLocalBuf->buffer.begin(), cpuLocalBuf->buffer.end());
if (!cpuLocalBuf->digest) {
cpuLocalBuf->digest = std::make_unique<DigestT>(digestSize_);
}
......
folly/stats/test/DigestBuilderBenchmark.cpp
View file @ 82fb08de
......@@ -93,19 +93,19 @@ BENCHMARK_RELATIVE_NAMED_PARAM_MULTI(append, 10000x32, 10000, 32)
* ============================================================================
* folly/stats/test/DigestBuilderBenchmark.cpp relative time/iter iters/s
* ============================================================================
* append(1000x1) 18.18ns 55.00M
* append(1000x2) 97.43% 18.66ns 53.58M
* append(1000x4) 93.91% 19.36ns 51.65M
* append(1000x8) 93.77% 19.39ns 51.57M
* append(1000x16) 93.78% 19.39ns 51.57M
* append(1000x32) 45.60% 39.87ns 25.08M
* append(1000x1) 25.90ns 38.61M
* append(1000x2) 99.27% 26.09ns 38.33M
* append(1000x4) 99.82% 25.95ns 38.54M
* append(1000x8) 98.54% 26.28ns 38.05M
* append(1000x16) 84.07% 30.81ns 32.46M
* append(1000x32) 82.58% 31.36ns 31.88M
* ----------------------------------------------------------------------------
* append(10000x1) 13.53ns 73.91M
* append(10000x2) 91.27% 14.82ns 67.46M
* append(10000x4) 90.38% 14.97ns 66.80M
* append(10000x8) 89.26% 15.16ns 65.97M
* append(10000x16) 88.97% 15.21ns 65.76M
* append(10000x32) 36.74% 36.83ns 27.15M
* append(10000x1) 25.34ns 39.46M
* append(10000x2) 99.75% 25.41ns 39.36M
* append(10000x4) 99.24% 25.54ns 39.16M
* append(10000x8) 106.97% 23.69ns 42.21M
* append(10000x16) 87.82% 28.86ns 34.65M
* append(10000x32) 72.99% 34.72ns 28.80M
* ============================================================================
*/
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment