Commit 8c88eb0a authored by Marcin Pawlowski's avatar Marcin Pawlowski Committed by Facebook Github Bot

try to improve folly/io/async/test:async_test - AsyncSocketTest.Write

Summary:
the test fails a lot as seen on the task.
To kill the connection in said test, we depeneded
on destructor, however this uses a delayed destruction
patter so I guess we did not destroy on time and
we were failing the tests.
I close socket explicitly. No idea if this misses
the point of whole test.

Reviewed By: yfeldblum

Differential Revision: D4171111

fbshipit-source-id: 01b8c97a04a2bcdfaeeea522ca8bcae343d6bb5d
parent 8e312461
......@@ -1067,7 +1067,7 @@ TEST(AsyncSocketTest, WritePipeError) {
// accept and immediately close the socket
std::shared_ptr<BlockingSocket> acceptedSocket = server.accept();
acceptedSocket.reset();
acceptedSocket->close();
// write() a large chunk of data
size_t writeLength = 8*1024*1024;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment