Deprecate folly::svformat

Summary: Deprecate folly::svformat in favor of fmt::format

Reviewed By: vitaut

Differential Revision: D30521196

fbshipit-source-id: 944054191bbfd296d1f666eb6ace6c4308f6d1ea

folly/Format.h

@@ -295,7 +295,11 @@ Formatter<true, Container> vformat(StringPiece fmt, Container&& container) {
  * intermediate format object.
  */
 template <class Container>
-inline std::string svformat(StringPiece fmt, Container&& container) {
+[[deprecated(
+    "Use fmt::format instead of folly::svformat for better performance, build "
+    "times and compatibility with std::format")]] //
+inline std::string
+svformat(StringPiece fmt, Container&& container) {
   return vformat(fmt, std::forward<Container>(container)).str();
 }
 

folly/logging/test/CustomLogFormatterTest.cpp

@@ -26,6 +26,8 @@
 #include <folly/portability/GTest.h>
 #include <folly/portability/Stdlib.h>
 
+FOLLY_GNU_DISABLE_WARNING("-Wdeprecated-declarations")
+
 using namespace folly;
 
 namespace {

folly/logging/test/GlogFormatterTest.cpp

@@ -25,6 +25,8 @@
 #include <folly/portability/GTest.h>
 #include <folly/portability/Stdlib.h>
 
+FOLLY_GNU_DISABLE_WARNING("-Wdeprecated-declarations")
+
 using namespace folly;
 
 namespace {

folly/test/DynamicConverterTest.cpp

@@ -25,6 +25,8 @@
 #include <folly/FBVector.h>
 #include <folly/portability/GTest.h>
 
+FOLLY_GNU_DISABLE_WARNING("-Wdeprecated-declarations")
+
 using namespace folly;
 using namespace folly::dynamicconverter_detail;
 

folly/test/FormatOtherTest.cpp

@@ -26,6 +26,8 @@
 #include <folly/portability/GTest.h>
 #include <folly/small_vector.h>
 
+FOLLY_GNU_DISABLE_WARNING("-Wdeprecated-declarations")
+
 using namespace folly;
 
 TEST(FormatOther, dynamic) {